Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(map_based_prediction): use autoware utils #547

Merged
merged 2 commits into from
Mar 18, 2022
Merged

fix(map_based_prediction): use autoware utils #547

merged 2 commits into from
Mar 18, 2022

Conversation

purewater0901
Copy link
Contributor

@purewater0901 purewater0901 commented Mar 18, 2022 •
edited
Loading

Description

Use radian normalize function from autoware_utils and also fix yaw angle calculation in prediction

Pre-review checklist for the PR author

PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has the write access can merge the PR.

yukkysaito
yukkysaito previously approved these changes Mar 18, 2022
View reviewed changes
@codecov
Copy link

codecov bot commented Mar 18, 2022 •
edited
Loading

Codecov Report

Merging #547 (9d05a7f) into main (d9460e5) will decrease coverage by 10.97%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #547       +/-   ##
==========================================
- Coverage   10.97%   0.00%   -10.98%     
==========================================
  Files         708       4      -704     
  Lines       49776     591    -49185     
  Branches     7128       0     -7128     
==========================================
- Hits         5464       0     -5464     
+ Misses      39926     591    -39335     
+ Partials     4386       0     -4386
Impacted Files Coverage Δ
...based_prediction/src/map_based_prediction_node.cpp 0.00% <0.00%> (ø)
...anning_rviz_plugin/src/tools/jsk_overlay_utils.cpp
...ware_utils/src/planning/planning_marker_helper.cpp
map/lanelet2_extension/lib/query.cpp
...city_planner/src/scene_module/blind_spot/debug.cpp
...ult_injection/test/src/test_diagnostic_storage.cpp
.../scenario_selector_node/scenario_selector_node.cpp
...c/scene_module/intersection/scene_intersection.cpp
...ule/intersection/scene_merge_from_private_road.cpp
...wer/include/trajectory_follower/mpc_trajectory.hpp
... and 695 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 098d324...9d05a7f. Read the comment docs.

@purewater0901 purewater0901 merged commit 0c6643e into autowarefoundation:main Mar 18, 2022
@purewater0901 purewater0901 deleted the fix/prediction_yaw_angle branch March 18, 2022 14:04
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Mar 19, 2022
Merged
k-obitsu pushed a commit to k-obitsu/autoware.universe that referenced this pull request Mar 19, 2022
@taikitanaka3 @wep21
@kenji-miyake @tkimura4 @kmiya @YoheiMishina @pre-commit-ci
feat: add goal distance calculator package (autowarefoundation#36)
b725734 
* Feature/goal distance calculator (autowarefoundation#311)

* add initial package

* half lint

* pass cpplint

* add pose deviation

* add autoware utils

* fix prefix

* beautify

* add ament copyright

* fix ament format

* fix param name

* refactor param

* refactor params

* [goal_sistance_calculator]: Fix CMakeLists.txt

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp>

* ros2-v0.8.0-goal_distance_calulator (autowarefoundation#319)

* update to component

* refactor node name

* Ros2 v0.8.0 lane departure checker (autowarefoundation#327)

* Add lane departure checker (autowarefoundation#928)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix bug of lane_departure_checker (autowarefoundation#1011)

* Fix bug of lane_departure_checker

Since preceeding lanelets are missing, when vehicle is at the beginning of a lanelet, it's mistakenly considered as out of lane.

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix typo

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Reduce computational cost of lane_departure_checker (autowarefoundation#1026)

Lanelet visualization will be too slow when big lanelets are visualized.

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix typo (autowarefoundation#1062)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* [lane_departure_checker]: Port to ROS2

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [lane_departure_checker]: Fix lint

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [autoware_utils]: Publish autoware debug msgs

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [lane_departure_checker]: Use autoware_debug_msgs instead of std_msgs

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [goal_distance_calculator]: Use autoware_debug_msgs instead of std_msgs

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [autoware_utils]: Add namespace to debug traits

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [lane_departure_checker]: Fix lint

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* Rename ROS-related .yaml to .param.yaml (autowarefoundation#352)

* Rename ROS-related .yaml to .param.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Remove prefix 'default_' of yaml files

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Rename vehicle_info.yaml to vehicle_info.param.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Rename diagnostic_aggregator's param files

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix overlooked parameters

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* add use_sim-time option (autowarefoundation#454)

* Unify Apache-2.0 license name (autowarefoundation#1242)

* Remove use_sim_time for set_parameter (autowarefoundation#1260)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Change formatter to clang-format and black (autowarefoundation#2332)

* Revert "Temporarily comment out pre-commit hooks"

This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3.

* Replace ament_lint_common with autoware_lint_common

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Remove ament_cmake_uncrustify and ament_clang_format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply Black

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply clang-format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix build errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix for cpplint

* Fix include double quotes to angle brackets

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply clang-format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix build errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add COLCON_IGNORE (autowarefoundation#500)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* goal_distance_calculator port to .auto (autowarefoundation#525)

* goal_distance_calculator port to .auto

* Fix formatting

* Fix pre commit

* [goal_distance_calculator]add readme (autowarefoundation#545)

* add readme

* Update common/util/goal_distance_calculator/Readme.md

Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>

* fix format

Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>

* [path_distance_calculator]add readme (autowarefoundation#547)

* add readme of path_distance_calculator

* update readme

* fix readme

* update description

* ci(pre-commit): autofix

Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp>
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>
Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>
Co-authored-by: Yohei Mishina <66298900+YoheiMishina@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
k-obitsu pushed a commit to k-obitsu/autoware.universe that referenced this pull request Mar 19, 2022
@taikitanaka3 @isamu-takagi
@KeisukeShima @kenji-miyake @takayuki5168 @tkimura4 @pre-commit-ci
feat: add path distance calculator package (autowarefoundation#37)
a29f7f7 
* Add path distance calculator (autowarefoundation#1520)

* Add path distance calculator

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Fix lint

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Use autoware_utils trajectory function

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Add const

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* add sort-package-xml hook in pre-commit (autowarefoundation#1881)

* add sort xml hook in pre-commit

* change retval to exit_status

* rename

* add prettier plugin-xml

* use early return

* add license note

* add tier4 license

* restore prettier

* change license order

* move local hooks to public repo

* move prettier-xml to pre-commit-hooks-ros

* update version for bug-fix

* apply pre-commit

* Change formatter to clang-format and black (autowarefoundation#2332)

* Revert "Temporarily comment out pre-commit hooks"

This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3.

* Replace ament_lint_common with autoware_lint_common

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Remove ament_cmake_uncrustify and ament_clang_format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply Black

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply clang-format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix build errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix for cpplint

* Fix include double quotes to angle brackets

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply clang-format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix build errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add COLCON_IGNORE (autowarefoundation#500)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* port path distance calculator (autowarefoundation#498)

* port path distance calculator

* remove ignore

Co-authored-by: Takayuki Murooka <takayuki.murooka@tier4.jp>
Co-authored-by: tanaka3 <ttatcoder@outlook.jp>

* [path_distance_calculator]add readme (autowarefoundation#547)

* add readme of path_distance_calculator

* update readme

* fix readme

* update description

* ci(pre-commit): autofix

Co-authored-by: Takagi, Isamu <43976882+isamu-takagi@users.noreply.github.com>
Co-authored-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
Co-authored-by: Takayuki Murooka <takayuki.murooka@tier4.jp>
Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request Apr 11, 2022
@purewater0901 @satoshi-ota
fix(map_based_prediction): use autoware utils (autowarefoundation#547)
3bdd448 
* use autoware utils

* add const
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request Apr 23, 2022
@purewater0901 @satoshi-ota
fix(map_based_prediction): use autoware utils (autowarefoundation#547)
c84e13b 
* use autoware utils

* add const
tkimura4 pushed a commit to tkimura4/autoware.universe that referenced this pull request Apr 28, 2022
@purewater0901 @tkimura4
fix(map_based_prediction): use autoware utils (autowarefoundation#547)
b1a2fe8 
* use autoware utils

* add const
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request May 20, 2022
@purewater0901 @satoshi-ota
fix(map_based_prediction): use autoware utils (autowarefoundation#547)
30ef89f 
* use autoware utils

* add const
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request May 20, 2022
@purewater0901 @satoshi-ota
fix(map_based_prediction): use autoware utils (autowarefoundation#547)
fd7772d 
* use autoware utils

* add const
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request May 30, 2022
@purewater0901 @satoshi-ota
fix(map_based_prediction): use autoware utils (autowarefoundation#547)
a7504a3 
* use autoware utils

* add const
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request May 31, 2022
@purewater0901 @satoshi-ota
fix(map_based_prediction): use autoware utils (autowarefoundation#547)
5c048c4 
* use autoware utils

* add const
dmoszynski pushed a commit to RobotecAI/autoware.universe that referenced this pull request Jun 22, 2023
@tier4-autoware-public-bot
Merge pull request autowarefoundation#547 from tier4/sync-upstream
b65c338 
chore: sync upstream
kyoichi-sugahara pushed a commit that referenced this pull request Sep 16, 2023
@tier4-autoware-private-bot @kenji-miyake
chore: sync files (#547)
b3261d6 
Signed-off-by: GitHub <noreply@github.com>

Signed-off-by: GitHub <noreply@github.com>
Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yukkysaito yukkysaito yukkysaito approved these changes

@TakaHoribe TakaHoribe Awaiting requested review from TakaHoribe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@purewater0901 @yukkysaito