-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(trajectory_follower): change default param for curvature smoothing #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
satoshi-ota
pushed a commit
to satoshi-ota/autoware.universe
that referenced
this pull request
Mar 14, 2022
* Add path distance calculator (autowarefoundation#1520) * Add path distance calculator Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Fix lint Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Use autoware_utils trajectory function Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Add const Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * add sort-package-xml hook in pre-commit (autowarefoundation#1881) * add sort xml hook in pre-commit * change retval to exit_status * rename * add prettier plugin-xml * use early return * add license note * add tier4 license * restore prettier * change license order * move local hooks to public repo * move prettier-xml to pre-commit-hooks-ros * update version for bug-fix * apply pre-commit * Change formatter to clang-format and black (autowarefoundation#2332) * Revert "Temporarily comment out pre-commit hooks" This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3. * Replace ament_lint_common with autoware_lint_common Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove ament_cmake_uncrustify and ament_clang_format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply Black Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply clang-format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix build errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix for cpplint * Fix include double quotes to angle brackets Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply clang-format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix build errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add COLCON_IGNORE (autowarefoundation#500) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * port path distance calculator (autowarefoundation#498) * port path distance calculator * remove ignore Co-authored-by: Takayuki Murooka <takayuki.murooka@tier4.jp> Co-authored-by: tanaka3 <ttatcoder@outlook.jp> * [path_distance_calculator]add readme (autowarefoundation#547) * add readme of path_distance_calculator * update readme * fix readme * update description * ci(pre-commit): autofix Co-authored-by: Takagi, Isamu <43976882+isamu-takagi@users.noreply.github.com> Co-authored-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com> Co-authored-by: Takayuki Murooka <takayuki.murooka@tier4.jp> Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
tkimura4
approved these changes
Mar 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
yn-mrse
referenced
this pull request
in tier4/autoware.universe
Apr 8, 2022
#498) Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
boyali
referenced
this pull request
in boyali/autoware.universe
Sep 28, 2022
tier4#498) Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
boyali
referenced
this pull request
in boyali/autoware.universe
Oct 3, 2022
tier4#498) Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
boyali
referenced
this pull request
in boyali/autoware.universe
Oct 19, 2022
tier4#498) Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
tkimura4
referenced
this pull request
in tier4/autoware.universe
Oct 24, 2022
Signed-off-by: GitHub <noreply@github.com> Signed-off-by: GitHub <noreply@github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>
dmoszynski
pushed a commit
to RobotecAI/autoware.universe
that referenced
this pull request
Jun 22, 2023
chore: sync upstream
keiota
pushed a commit
to keiota/autoware.universe
that referenced
this pull request
Aug 17, 2023
… check (autowarefoundation#498) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
HansOersted
pushed a commit
to HansOersted/autoware.universe
that referenced
this pull request
Mar 8, 2024
Update repos files Co-authored-by: GitHub Actions <actions@example.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(required)
None.
Description(required)
The value
1
for this parameter causes a noisy steering command. Set default back to15
as in the previous version.Note that for the vehicle driving a narrow road with high tracking precision, please keep using
1
value.Review Procedure(required)
Related PR(optional)
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
If you are adding new package following items are required:
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks