Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(trajectory_follower): change default param for curvature smoothing #498

Merged
merged 1 commit into from
Mar 16, 2022

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Mar 8, 2022

Related Issue(required)

None.

Description(required)

The value 1 for this parameter causes a noisy steering command. Set default back to 15 as in the previous version.

Note that for the vehicle driving a narrow road with high tracking precision, please keep using 1 value.

Review Procedure(required)

Related PR(optional)

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

If you are adding new package following items are required:

  • Documentation with description of the package is available
  • A sample launch file and parameter file are available if the package contains executable nodes

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR / build-and-test-pr: Required to pass before the merge.
  • Build and test for PR / clang-tidy-pr: NOT required to pass before the merge. It is up to the reviewer(s). Found false positives? See the [guidelines][clang-tidy-guidelines].
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@TakaHoribe TakaHoribe requested a review from tkimura4 March 8, 2022 10:59
@codecov
Copy link

codecov bot commented Mar 8, 2022

Codecov Report

Merging #498 (ea7822b) into main (9114b66) will increase coverage by 24.39%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #498       +/-   ##
===========================================
+ Coverage   10.95%   35.34%   +24.39%     
===========================================
  Files         704        7      -697     
  Lines       49671     1372    -48299     
  Branches     6655      850     -5805     
===========================================
- Hits         5440      485     -4955     
+ Misses      39869      161    -39708     
+ Partials     4362      726     -3636     
Impacted Files Coverage Δ
..._departure_checker_node/lane_departure_checker.cpp
...pure_pursuit/include/pure_pursuit/pure_pursuit.hpp
...nning/behavior_path_planner/src/path_utilities.cpp
...lude/lanelet2_extension/io/autoware_osm_parser.hpp
...er4_state_rviz_plugin/src/autoware_state_panel.cpp
...mon/autoware_auto_common/test/test_angle_utils.cpp
planning/motion_velocity_smoother/src/resample.cpp
...ude/scene_module/virtual_traffic_light/manager.hpp
...onitor/include/localization_error_monitor/node.hpp
...ulator/vehicle_model/sim_model_ideal_steer_vel.hpp
... and 687 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9114b66...ea7822b. Read the comment docs.

satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request Mar 14, 2022
* Add path distance calculator (autowarefoundation#1520)

* Add path distance calculator

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Fix lint

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Use autoware_utils trajectory function

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Add const

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* add sort-package-xml hook in pre-commit (autowarefoundation#1881)

* add sort xml hook in pre-commit

* change retval to exit_status

* rename

* add prettier plugin-xml

* use early return

* add license note

* add tier4 license

* restore prettier

* change license order

* move local hooks to public repo

* move prettier-xml to pre-commit-hooks-ros

* update version for bug-fix

* apply pre-commit

* Change formatter to clang-format and black (autowarefoundation#2332)

* Revert "Temporarily comment out pre-commit hooks"

This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3.

* Replace ament_lint_common with autoware_lint_common

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Remove ament_cmake_uncrustify and ament_clang_format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply Black

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply clang-format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix build errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix for cpplint

* Fix include double quotes to angle brackets

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply clang-format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix build errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add COLCON_IGNORE (autowarefoundation#500)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* port path distance calculator (autowarefoundation#498)

* port path distance calculator

* remove ignore

Co-authored-by: Takayuki Murooka <takayuki.murooka@tier4.jp>
Co-authored-by: tanaka3 <ttatcoder@outlook.jp>

* [path_distance_calculator]add readme (autowarefoundation#547)

* add readme of path_distance_calculator

* update readme

* fix readme

* update description

* ci(pre-commit): autofix

Co-authored-by: Takagi, Isamu <43976882+isamu-takagi@users.noreply.github.com>
Co-authored-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
Co-authored-by: Takayuki Murooka <takayuki.murooka@tier4.jp>
Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkimura4 tkimura4 merged commit dd6c482 into autowarefoundation:main Mar 16, 2022
@tkimura4 tkimura4 deleted the fix/mpc-default-param branch March 16, 2022 10:35
yn-mrse referenced this pull request in tier4/autoware.universe Apr 8, 2022
#498)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
tier4#498)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
tier4#498)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
tier4#498)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
tkimura4 referenced this pull request in tier4/autoware.universe Oct 24, 2022
Signed-off-by: GitHub <noreply@github.com>

Signed-off-by: GitHub <noreply@github.com>
Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>
dmoszynski pushed a commit to RobotecAI/autoware.universe that referenced this pull request Jun 22, 2023
keiota pushed a commit to keiota/autoware.universe that referenced this pull request Aug 17, 2023
HansOersted pushed a commit to HansOersted/autoware.universe that referenced this pull request Mar 8, 2024
Update repos files

Co-authored-by: GitHub Actions <actions@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants