-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use hazard in auto command when emergency_handling is false #487
fix: use hazard in auto command when emergency_handling is false #487
Conversation
@tkimura4 If use_emergency_handling is false, does this mean that the hazard lights will turn on according to emergency stop even when emergency stop is not working? |
@yukkysaito |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tkimura4 Ok 👍 pls fix PR title
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
6bcac8e
to
2b43d94
Compare
@yukkysaito |
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
…velop sync main for develop
* Revert "fix(behavior_path_planner): handle overlap lane in isEgoOutOfRoute() (autowarefoundation#3715)" This reverts commit e229603. * feat(vehicle_cmd_gate): do not send current gear if autoware is not engaged (autowarefoundation#3683) This reverts commit be31385. Signed-off-by: Berkay Karaman <brkay54@gmail.com> * feat(shift_decider): send current gear if the autoware state is not driving (autowarefoundation#3684) Signed-off-by: Berkay Karaman <brkay54@gmail.com> --------- Signed-off-by: Berkay Karaman <brkay54@gmail.com> Co-authored-by: Berkay Karaman <brkay54@gmail.com>
…ction in crosswalk (autowarefoundation#487) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: GitHub <noreply@github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: tomoya.kimura tomoya.kimura@tier4.jp
Related Issue(required)
Description(required)
Fix porting miss in vehicle_cmd_gate.
https://github.com/tier4/AutowareArchitectureProposal.iv/blob/main/control/vehicle_cmd_gate/src/vehicle_cmd_gate.cpp#L309-310
When
use_emergency_handling
is false, use the auto_commands for hazard_lightReview Procedure(required)
Set
use_emergency_handling
to false in control.launch.pyLaunch planning simulator, and start to run the vehicle.
Transition the vehicle state to Emergency in some way, and confirm that the hazard lights are not enabled.
Related PR(optional)
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
If you are adding new package following items are required:
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks