Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use hazard in auto command when emergency_handling is false #487

Merged

Conversation

tkimura4
Copy link
Contributor

@tkimura4 tkimura4 commented Mar 7, 2022

Signed-off-by: tomoya.kimura tomoya.kimura@tier4.jp

Related Issue(required)

Description(required)

Fix porting miss in vehicle_cmd_gate.
https://github.com/tier4/AutowareArchitectureProposal.iv/blob/main/control/vehicle_cmd_gate/src/vehicle_cmd_gate.cpp#L309-310

When use_emergency_handling is false, use the auto_commands for hazard_light

Review Procedure(required)

Set use_emergency_handling to false in control.launch.py
Launch planning simulator, and start to run the vehicle.
Transition the vehicle state to Emergency in some way, and confirm that the hazard lights are not enabled.

Related PR(optional)

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

If you are adding new package following items are required:

  • Documentation with description of the package is available
  • A sample launch file and parameter file are available if the package contains executable nodes

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR / build-and-test-pr: Required to pass before the merge.
  • Build and test for PR / clang-tidy-pr: NOT required to pass before the merge. It is up to the reviewer(s). Found false positives? See the [guidelines][clang-tidy-guidelines].
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

@tkimura4 tkimura4 requested a review from taikitanaka3 March 7, 2022 07:16
@codecov
Copy link

codecov bot commented Mar 7, 2022

Codecov Report

Merging #487 (2b43d94) into main (6e3b9ea) will increase coverage by 7.90%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #487      +/-   ##
==========================================
+ Coverage   10.95%   18.86%   +7.90%     
==========================================
  Files         704        6     -698     
  Lines       49656      477   -49179     
  Branches     6655      203    -6452     
==========================================
- Hits         5442       90    -5352     
+ Misses      39852      360   -39492     
+ Partials     4362       27    -4335     
Impacted Files Coverage Δ
control/vehicle_cmd_gate/src/vehicle_cmd_gate.cpp 0.00% <0.00%> (ø)
...ene_module/occlusion_spot/occlusion_spot_utils.hpp
...ator/include/planning_evaluator/metrics/metric.hpp
...toware_auto_geometry/test/src/test_convex_hull.cpp
.../motion_velocity_smoother/src/trajectory_utils.cpp
map/lanelet2_extension/lib/detection_area.cpp
...autoware_utils/test/src/geometry/test_geometry.cpp
...clude/obstacle_avoidance_planner/marker_helper.hpp
...nclude/lidar_apollo_instance_segmentation/util.hpp
...vehicle_model/sim_model_delay_steer_acc_geared.cpp
... and 689 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e3b9ea...2b43d94. Read the comment docs.

@tkimura4 tkimura4 requested a review from yukkysaito March 8, 2022 05:50
@yukkysaito
Copy link
Contributor

yukkysaito commented Mar 8, 2022

@tkimura4 If use_emergency_handling is false, does this mean that the hazard lights will turn on according to emergency stop even when emergency stop is not working?

@tkimura4
Copy link
Contributor Author

tkimura4 commented Mar 8, 2022

@yukkysaito
Currently, yes. I fixed it on this PR.

yukkysaito
yukkysaito previously approved these changes Mar 8, 2022
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tkimura4 Ok 👍 pls fix PR title

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
@tkimura4 tkimura4 force-pushed the fix/vehicle_cmd_gate_hazard_light branch from 6bcac8e to 2b43d94 Compare March 8, 2022 06:09
@tkimura4 tkimura4 changed the title use hazard in auto command when emergency_handling is false fix: use hazard in auto command when emergency_handling is false Mar 8, 2022
@tkimura4
Copy link
Contributor Author

tkimura4 commented Mar 8, 2022

@yukkysaito
I changed title and commit message.
Please approve one more.

@yukkysaito yukkysaito self-requested a review March 8, 2022 06:11
@tkimura4 tkimura4 merged commit dba8be5 into autowarefoundation:main Mar 8, 2022
@tkimura4 tkimura4 deleted the fix/vehicle_cmd_gate_hazard_light branch March 8, 2022 08:08
1222-takeshi referenced this pull request in tier4/autoware.universe Mar 22, 2022
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
TomohitoAndo pushed a commit to TomohitoAndo/autoware.universe that referenced this pull request Oct 5, 2022
rej55 pushed a commit to rej55/autoware.universe that referenced this pull request May 19, 2023
* Revert "fix(behavior_path_planner): handle overlap lane in isEgoOutOfRoute() (autowarefoundation#3715)"

This reverts commit e229603.

* feat(vehicle_cmd_gate):  do not send current gear if autoware is not engaged (autowarefoundation#3683)

This reverts commit be31385.
Signed-off-by: Berkay Karaman <brkay54@gmail.com>

* feat(shift_decider): send current gear if the autoware state is not driving (autowarefoundation#3684)

Signed-off-by: Berkay Karaman <brkay54@gmail.com>

---------

Signed-off-by: Berkay Karaman <brkay54@gmail.com>
Co-authored-by: Berkay Karaman <brkay54@gmail.com>
keiota pushed a commit to keiota/autoware.universe that referenced this pull request Aug 17, 2023
…ction in crosswalk (autowarefoundation#487)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
kyoichi-sugahara pushed a commit that referenced this pull request Sep 16, 2023
Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>
HansOersted pushed a commit to HansOersted/autoware.universe that referenced this pull request Mar 8, 2024
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants