fix(vehicle_cmd_gate): fix the gear transition #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkimura4
requested review from
rej55,
kosuke55,
kyoichi-sugahara,
satoshi-ota,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168,
purewater0901 and
zulfaqar-azmi-t4
as code owners
TakaHoribe
approved these changes
May 17, 2023
…riving (autowarefoundation#3684) Signed-off-by: Berkay Karaman <brkay54@gmail.com>
…ngaged (autowarefoundation#3683) This reverts commit be31385. Signed-off-by: Berkay Karaman <brkay54@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hotfix to beta/v0.8.0
autowarefoundation#3683
autowarefoundation#3684
( Solve this Issue about gear. )
Related links
autowarefoundation#3683
autowarefoundation#3684
Tests performed
I confirmed that it worked well on actual vehicle.
Notes for reviewers
none
Interface changes
none
Effects on system behavior
Solve the issue that the gear does not change to PARKING on goal.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.