Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gear is not changed to PARK on goal anymore. #3526

Closed
3 tasks done
VRichardJP opened this issue Apr 25, 2023 · 2 comments · Fixed by #3684
Closed
3 tasks done

Gear is not changed to PARK on goal anymore. #3526

VRichardJP opened this issue Apr 25, 2023 · 2 comments · Fixed by #3684
Assignees
Labels
component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) type:bug Software flaws or errors.

Comments

@VRichardJP
Copy link
Contributor

Checklist

  • I've read the contribution guidelines.
  • I've searched other issues and no duplicate issues were found.
  • I'm convinced that this is not my fault but a bug.

Description

During a recent test drive, I observed Autoware does not change the vehicle gear to PARK anymore upon reaching goal. Normally, this piece of code is supposed to do so when ARRIVED_GOAL state is received:

if (autoware_state_->state == AutowareState::ARRIVED_GOAL && park_on_goal_) {
shift_cmd_.command = GearCommand::PARK;

Upon arrival, Autoware state changes quickly from DRIVING to ARRIVED_GOAL, to FINALIZING, then back to WAITING_FOR_ROUTE. Autoware is always in Autonomous mode and the vehicle is always engaged.

Expected behavior

Gear is changed to park upon arrival if park_on_goal_ is true

Actual behavior

Gear unchanged.

Steps to reproduce

Drive autonomously to any goal.

Versions

No response

Possible causes

No response

Additional context

No response

@VRichardJP VRichardJP added type:bug Software flaws or errors. component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) labels Apr 25, 2023
@brkay54
Copy link
Member

brkay54 commented May 11, 2023

I couldn't observe the problem at commit sha in the universe: f627fc30a6730af52348e0605437d7ed6806170e (the latest commit)

Could you recheck whether the issue still occurs or not?

@brkay54
Copy link
Member

brkay54 commented May 11, 2023

Sorry for my mistake, it still occurs. I am going to work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) type:bug Software flaws or errors.
Projects
None yet
2 participants