-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(build): remove tier4_autoware_utils.hpp in common/ #4828
chore(build): remove tier4_autoware_utils.hpp in common/ #4828
Conversation
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To accelerate the build time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #4828 +/- ##
========================================
Coverage 15.11% 15.12%
========================================
Files 1573 1572 -1
Lines 108363 108342 -21
Branches 33278 33683 +405
========================================
+ Hits 16384 16385 +1
+ Misses 74125 74096 -29
- Partials 17854 17861 +7
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
@isamu-takagi Can you approve this PR ? |
Description
#4821
depends: #4829
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.