Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): remove tier4_autoware_utils.hpp in common/ #4828

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Aug 31, 2023

Description

#4821

depends: #4829

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@github-actions github-actions bot added component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Aug 31, 2023
Copy link
Contributor

@TakaHoribe TakaHoribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To accelerate the build time.

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soblin soblin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 31, 2023
@soblin soblin enabled auto-merge (squash) August 31, 2023 08:50
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (8e6d440) 15.11% compared to head (669c81d) 15.12%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #4828    +/-   ##
========================================
  Coverage   15.11%   15.12%            
========================================
  Files        1573     1572     -1     
  Lines      108363   108342    -21     
  Branches    33278    33683   +405     
========================================
+ Hits        16384    16385     +1     
+ Misses      74125    74096    -29     
- Partials    17854    17861     +7     
Flag Coverage Δ *Carryforward flag
differential 18.51% <ø> (?)
total 15.13% <ø> (+0.01%) ⬆️ Carriedforward from df08305

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...otion_utils/marker/virtual_wall_marker_creator.hpp 50.00% <ø> (ø)
common/motion_utils/src/marker/marker_helper.cpp 55.00% <ø> (ø)
...n_utils/src/marker/virtual_wall_marker_creator.cpp 81.08% <ø> (ø)
...stance_calculator/src/path_distance_calculator.cpp 0.00% <ø> (ø)
control/mpc_lateral_controller/src/mpc.cpp 46.73% <ø> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soblin
Copy link
Contributor Author

soblin commented Aug 31, 2023

@isamu-takagi Can you approve this PR ?

@soblin soblin merged commit ade1c41 into autowarefoundation:main Sep 1, 2023
@soblin soblin deleted the build-fast2/common/remove-tier4_autoware_utils_hpp branch September 1, 2023 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants