Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(out_of_lane): handle undetected overlap edge cases #4761

Conversation

maxime-clem
Copy link
Contributor

Description

This PR fixes bugs with the out_of_lane module where some lanelets could incorrectly be considered as "other" lanes that should not be entered by ego.
The bug was caused by the boost::geometry::overlaps function which does not consider the case of the following picture as an overlap.

image

With this PR, we add checks with boost::geometry::within to handle cases where one lanelet is inside the other (e.g., in the picture, blue is inside red).

Tests performed

Psim

Effects on system behavior

Prevents some unwanted stops caused by the out_of_lane module

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem maxime-clem added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 26, 2023
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Aug 26, 2023
@codecov
Copy link

codecov bot commented Aug 26, 2023

Codecov Report

Patch coverage: 12.50% and no project coverage change.

Comparison is base (febb7d5) 15.10% compared to head (e8cb69d) 15.10%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4761   +/-   ##
=======================================
  Coverage   15.10%   15.10%           
=======================================
  Files        1563     1563           
  Lines      107946   107950    +4     
  Branches    33140    33143    +3     
=======================================
+ Hits        16303    16304    +1     
- Misses      73871    73874    +3     
  Partials    17772    17772           
Flag Coverage Δ *Carryforward flag
differential 24.11% <12.50%> (?)
total 15.10% <ø> (+<0.01%) ⬆️ Carriedforward from febb7d5

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...city_out_of_lane_module/src/lanelets_selection.cpp 31.03% <12.50%> (-0.97%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxime-clem maxime-clem merged commit 39e5999 into autowarefoundation:main Sep 1, 2023
@maxime-clem maxime-clem deleted the fix/out_of_lane-overlap-edgecase branch September 1, 2023 01:44
maxime-clem added a commit to tier4/autoware.universe that referenced this pull request Sep 4, 2023
…ation#4761)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
maxime-clem added a commit to tier4/autoware.universe that referenced this pull request Sep 4, 2023
…ation#4761)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
maxime-clem added a commit to tier4/autoware.universe that referenced this pull request Sep 4, 2023
…ation#4761)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
maxime-clem added a commit to tier4/autoware.universe that referenced this pull request Sep 12, 2023
…ation#4761)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
maxime-clem added a commit to tier4/autoware.universe that referenced this pull request Sep 14, 2023
…ation#4761)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Sep 15, 2023
…ation#4761)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
maxime-clem added a commit to maxime-clem/autoware.universe that referenced this pull request Sep 25, 2023
…ation#4761)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants