-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(out_of_lane): handle undetected overlap edge cases #4761
Merged
maxime-clem
merged 1 commit into
autowarefoundation:main
from
maxime-clem:fix/out_of_lane-overlap-edgecase
Sep 1, 2023
Merged
fix(out_of_lane): handle undetected overlap edge cases #4761
maxime-clem
merged 1 commit into
autowarefoundation:main
from
maxime-clem:fix/out_of_lane-overlap-edgecase
Sep 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
maxime-clem
added
the
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Aug 26, 2023
maxime-clem
requested review from
shmpwk,
takayuki5168 and
tkimura4
as code owners
August 26, 2023 09:25
github-actions
bot
added
the
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
label
Aug 26, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4761 +/- ##
=======================================
Coverage 15.10% 15.10%
=======================================
Files 1563 1563
Lines 107946 107950 +4
Branches 33140 33143 +3
=======================================
+ Hits 16303 16304 +1
- Misses 73871 73874 +3
Partials 17772 17772
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
takayuki5168
approved these changes
Aug 31, 2023
maxime-clem
added a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 4, 2023
…ation#4761) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
maxime-clem
added a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 4, 2023
…ation#4761) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
maxime-clem
added a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 4, 2023
…ation#4761) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
4 tasks
maxime-clem
added a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 12, 2023
…ation#4761) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
maxime-clem
added a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 14, 2023
…ation#4761) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
takayuki5168
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 15, 2023
…ation#4761) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
4 tasks
maxime-clem
added a commit
to maxime-clem/autoware.universe
that referenced
this pull request
Sep 25, 2023
…ation#4761) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes bugs with the
out_of_lane
module where some lanelets could incorrectly be considered as "other" lanes that should not be entered by ego.The bug was caused by the
boost::geometry::overlaps
function which does not consider the case of the following picture as an overlap.With this PR, we add checks with
boost::geometry::within
to handle cases where one lanelet is inside the other (e.g., in the picture, blue is inside red).Tests performed
Psim
Effects on system behavior
Prevents some unwanted stops caused by the
out_of_lane
modulePre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.