Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_planner)!: remove macro #4106

Merged

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Jun 28, 2023

Description

We decided to transit new bpp manager. Therefore, the behavior tree manager is no longer needed. So, I remove macro USE_OLD_ARCHITECTURE in this PR.

Related link:

Tests performed

Effects on system behavior

Nothing.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jun 28, 2023
@satoshi-ota satoshi-ota marked this pull request as ready for review June 28, 2023 10:13
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (df8a43a) 14.36% compared to head (1b771b3) 14.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4106      +/-   ##
==========================================
- Coverage   14.36%   14.36%   -0.01%     
==========================================
  Files        1567     1567              
  Lines      107880   107873       -7     
  Branches    31252    31248       -4     
==========================================
- Hits        15499    15496       -3     
+ Misses      75528    75522       -6     
- Partials    16853    16855       +2     
Flag Coverage Δ *Carryforward flag
differential 13.64% <0.00%> (?)
total 14.36% <0.00%> (-0.01%) ⬇️ Carriedforward from 2246931

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ception/tensorrt_yolox/src/tensorrt_yolox_node.cpp 0.00% <ø> (ø)
...lanner/scene_module/avoidance/avoidance_module.hpp 0.00% <ø> (ø)
...ule/dynamic_avoidance/dynamic_avoidance_module.hpp 0.00% <ø> (ø)
.../scene_module/goal_planner/goal_planner_module.hpp 20.00% <ø> (ø)
...th_planner/scene_module/lane_change/base_class.hpp 16.27% <ø> (ø)
...r_path_planner/scene_module/lane_change/normal.hpp 0.00% <ø> (ø)
...th_planner/scene_module/scene_module_interface.hpp 16.53% <ø> (ø)
...nner/scene_module/side_shift/side_shift_module.hpp 0.00% <ø> (ø)
...cene_module/start_planner/start_planner_module.hpp 0.00% <ø> (ø)
.../utils/goal_planner/default_fixed_goal_planner.hpp 100.00% <ø> (ø)
... and 10 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@satoshi-ota satoshi-ota changed the title feat!(behavior_path_planner): remove macro feat(behavior_path_planner)!: remove macro Jun 28, 2023
@satoshi-ota satoshi-ota merged commit df3f7b8 into autowarefoundation:main Jun 28, 2023
@satoshi-ota satoshi-ota deleted the refactor/remove-macro branch June 28, 2023 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants