Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(simple_planning_simulator): old style arg for static_tf_publisher #3736

Merged
merged 2 commits into from
Jun 14, 2023

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented May 17, 2023

Description

Fix old-style arg for static_tf_publisher to remove the following error:

[static_transform_publisher-48] [WARN 1684291838.681769706] [] parse_args(): Old-style arguments are deprecated; see --help for new-style arguments:(L258)

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@TakaHoribe TakaHoribe requested review from tkimura4 and a team as code owners May 17, 2023 09:53
@TakaHoribe TakaHoribe added the component:simulation Virtual environment setups and simulations. (auto-assigned) label May 17, 2023
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (14b183f) 14.46% compared to head (938a21f) 14.46%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3736   +/-   ##
=======================================
  Coverage   14.46%   14.46%           
=======================================
  Files        1431     1431           
  Lines      100789   100789           
  Branches    29726    29726           
=======================================
  Hits        14581    14581           
  Misses      70411    70411           
  Partials    15797    15797           
Flag Coverage Δ *Carryforward flag
differential 59.05% <ø> (?)
total 14.46% <ø> (ø) Carriedforward from ad5d61e

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

…ulator.launch.py

Co-authored-by: Maxime CLEMENT <78338830+maxime-clem@users.noreply.github.com>
Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkimura4 tkimura4 merged commit 7a0e1c0 into autowarefoundation:main Jun 14, 2023
@tkimura4 tkimura4 deleted the fix-old-style-sim branch June 14, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:simulation Virtual environment setups and simulations. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants