Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(intersection): fix occlusion rtc distance #3539

Merged

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Apr 26, 2023

Description

Always send proper RTC distance for intersection_occlusion

Related links

Tests performed

After this PR

When all modules are approved and there is no occlusion:

  • intersection(default): distance is finite
  • intersection(occlusion): distance is -inf because occlusion does not exist

image

When all modules are disapproved:

  • intersection(default): distance is finite
  • intersection(occlusion): distance is finite

image

When all modules are disapprove,d the car will wait at the first stop line even if it waited for more than the specified time of 2 phase stop.

image

Notes for reviewers

Interface changes

rtc distance is properly set for FOA

Effects on system behavior

rtc distance is properly set for FOA

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Apr 26, 2023
soblin added 3 commits April 26, 2023 16:43
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
…tion

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@soblin soblin force-pushed the intersection/occlusion-rtc-distance branch from d63a474 to b70057e Compare April 26, 2023 09:54
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@soblin soblin marked this pull request as ready for review April 26, 2023 10:14
@soblin soblin changed the title Intersection/occlusion rtc distance fix(intersection): fix occlusion rtc distance Apr 26, 2023
soblin added a commit to soblin/autoware.universe that referenced this pull request Apr 26, 2023
@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (761177e) 14.07% compared to head (0d69ae7) 14.07%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3539   +/-   ##
=======================================
  Coverage   14.07%   14.07%           
=======================================
  Files        1399     1399           
  Lines       97914    97913    -1     
  Branches    29066    29067    +1     
=======================================
  Hits        13778    13778           
+ Misses      69474    69473    -1     
  Partials    14662    14662           
Flag Coverage Δ *Carryforward flag
differential 3.45% <0.00%> (?)
total 14.07% <ø> (+<0.01%) ⬆️ Carriedforward from 761177e

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...e/scene_module/intersection/scene_intersection.hpp 0.00% <0.00%> (ø)
..._planner/src/scene_module/intersection/manager.cpp 0.00% <0.00%> (ø)
...c/scene_module/intersection/scene_intersection.cpp 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@soblin soblin merged commit 2c3a860 into autowarefoundation:main Apr 26, 2023
@soblin soblin deleted the intersection/occlusion-rtc-distance branch April 26, 2023 11:14
soblin added a commit to tier4/autoware.universe that referenced this pull request May 1, 2023
* always set RTC distance to default stop line/occlusion stop line

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* initialize RTC status as non occluded at intersection module construction

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* removed debug print

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* keep waiting at 1st stop lineif externally occlusion is requested

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

---------

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
soblin added a commit to soblin/autoware.universe that referenced this pull request May 7, 2023
* always set RTC distance to default stop line/occlusion stop line

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* initialize RTC status as non occluded at intersection module construction

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* removed debug print

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* keep waiting at 1st stop lineif externally occlusion is requested

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

---------

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Mingyu1991 pushed a commit to Mingyu1991/autoware.universe that referenced this pull request Jun 26, 2023
* always set RTC distance to default stop line/occlusion stop line

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* initialize RTC status as non occluded at intersection module construction

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* removed debug print

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* keep waiting at 1st stop lineif externally occlusion is requested

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

---------

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants