-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(intersection): fix occlusion rtc distance #3539
Merged
soblin
merged 4 commits into
autowarefoundation:main
from
soblin:intersection/occlusion-rtc-distance
Apr 26, 2023
Merged
fix(intersection): fix occlusion rtc distance #3539
soblin
merged 4 commits into
autowarefoundation:main
from
soblin:intersection/occlusion-rtc-distance
Apr 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
label
Apr 26, 2023
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
…tion Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
soblin
force-pushed
the
intersection/occlusion-rtc-distance
branch
from
April 26, 2023 09:54
d63a474
to
b70057e
Compare
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
soblin
requested review from
kosuke55,
kyoichi-sugahara,
mkuri,
maxime-clem,
satoshi-ota,
shmpwk,
taikitanaka3,
takayuki5168,
TomohitoAndo,
tkimura4,
purewater0901 and
a team
as code owners
April 26, 2023 10:14
soblin
changed the title
Intersection/occlusion rtc distance
fix(intersection): fix occlusion rtc distance
Apr 26, 2023
soblin
added a commit
to soblin/autoware.universe
that referenced
this pull request
Apr 26, 2023
takayuki5168
approved these changes
Apr 26, 2023
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #3539 +/- ##
=======================================
Coverage 14.07% 14.07%
=======================================
Files 1399 1399
Lines 97914 97913 -1
Branches 29066 29067 +1
=======================================
Hits 13778 13778
+ Misses 69474 69473 -1
Partials 14662 14662
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
soblin
added a commit
to tier4/autoware.universe
that referenced
this pull request
May 1, 2023
* always set RTC distance to default stop line/occlusion stop line Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * initialize RTC status as non occluded at intersection module construction Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * removed debug print Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * keep waiting at 1st stop lineif externally occlusion is requested Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> --------- Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
7 tasks
soblin
added a commit
to soblin/autoware.universe
that referenced
this pull request
May 7, 2023
* always set RTC distance to default stop line/occlusion stop line Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * initialize RTC status as non occluded at intersection module construction Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * removed debug print Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * keep waiting at 1st stop lineif externally occlusion is requested Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> --------- Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Mingyu1991
pushed a commit
to Mingyu1991/autoware.universe
that referenced
this pull request
Jun 26, 2023
* always set RTC distance to default stop line/occlusion stop line Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * initialize RTC status as non occluded at intersection module construction Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * removed debug print Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * keep waiting at 1st stop lineif externally occlusion is requested Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> --------- Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Always send proper RTC distance for intersection_occlusion
Related links
Tests performed
After this PR
When all modules are approved and there is no occlusion:
When all modules are disapproved:
When all modules are disapprove,d the car will wait at the first stop line even if it waited for more than the specified time of 2 phase stop.
Notes for reviewers
Interface changes
rtc distance is properly set for FOA
Effects on system behavior
rtc distance is properly set for FOA
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.