Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update expired links and fix internal links #2842

Merged
merged 9 commits into from
Feb 14, 2023

Conversation

HansRobo
Copy link
Member

@HansRobo HansRobo commented Feb 8, 2023

Description

Fix apollo's link and internal link

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

Tracked by #2841

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added component:common Common packages from the autoware-common repository. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) labels Feb 8, 2023
@HansRobo HansRobo mentioned this pull request Feb 8, 2023
3 tasks
@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Base: 12.48% // Head: 11.62% // Decreases project coverage by -0.87% ⚠️

Coverage data is based on head (b101811) compared to base (a2ba6dc).
Patch has no changes to coverable lines.

❗ Current head b101811 differs from pull request most recent head 38800d7. Consider uploading reports for the commit 38800d7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2842      +/-   ##
==========================================
- Coverage   12.48%   11.62%   -0.87%     
==========================================
  Files        1214     1321     +107     
  Lines       85906    92138    +6232     
  Branches    24506    24441      -65     
==========================================
- Hits        10728    10712      -16     
- Misses      63991    70245    +6254     
+ Partials    11187    11181       -6     
Flag Coverage Δ *Carryforward flag
differential 36.64% <ø> (?)
total 11.62% <ø> (-0.87%) ⬇️ Carriedforward from 1e90380

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...planning_evaluator/src/planning_evaluator_node.cpp 34.37% <0.00%> (-2.09%) ⬇️
...nning_simulator/simple_planning_simulator_core.cpp 37.42% <0.00%> (-1.96%) ⬇️
...erception/traffic_light_classifier/src/nodelet.cpp 0.00% <0.00%> (ø)
...on/tier4_planning_rviz_plugin/src/path/display.cpp 0.00% <0.00%> (ø)
...rol/operation_mode_transition_manager/src/node.cpp 0.00% <0.00%> (ø)
...lanning_rviz_plugin/src/path_footprint/display.cpp 0.00% <0.00%> (ø)
...on_planner/src/mission_planner/arrival_checker.cpp 0.00% <0.00%> (ø)
...on_planner/src/mission_planner/mission_planner.cpp 0.00% <0.00%> (ø)
...ing_rviz_plugin/include/path_footprint/display.hpp 0.00% <0.00%> (ø)
...path_planner/src/scene_module/lane_change/util.cpp 0.00% <0.00%> (ø)
... and 127 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@HansRobo HansRobo marked this pull request as ready for review February 8, 2023 10:11
@HansRobo
Copy link
Member Author

HansRobo commented Feb 8, 2023

pre-commit-optional is still failed due to something wrong in its own action.
I found it fails after loading this file.
But anyway, it is out of scope for this PR!

@taikitanaka3
Copy link
Contributor

@yukkysaito
Can you review this PR for code owner?

HansRobo and others added 7 commits February 9, 2023 10:09
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
@HansRobo
Copy link
Member Author

HansRobo commented Feb 14, 2023

@ambroise-arm @1222-takeshi @tkimura4
Can you review this PR as a code owner?

Note:

  • plotjuggler.io is down now. So, I am asking the owner to fix it
  • Somehow, precommit-optional is failed even though all checks succeeded. But it is out of scope for this pull request

@kenji-miyake kenji-miyake changed the title fix(doc): update expired links and fix internal links docs: update expired links and fix internal links Feb 14, 2023
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Copy link
Contributor

@kenji-miyake kenji-miyake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's okay for everyone to merge this.

@kenji-miyake kenji-miyake merged commit 54fd689 into autowarefoundation:main Feb 14, 2023
@HansRobo HansRobo deleted the fix-links branch February 14, 2023 11:57
nabetetsu pushed a commit to xygyo77/autoware.universe that referenced this pull request Mar 1, 2023
…#2842)

* fix(doc/link): update apollo documentation link

Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>

* fix(doc/link): fix internal link

Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>

* chore(doc): comment-out a figure that does not exist

Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>

* chore(doc): add {} to avoid recognize as a markdown link

Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>

* chore(doc): add {} to avoid recognize as a markdown link

Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>

* chore(doc): fix the hash of apollo link

Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>

* chore(doc): fix the hash of apollo link

Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>

* chore(doc): replace TierIV with TIER IV

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

---------

Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants