Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: typo and expired link #2841

Closed
3 tasks done
taikitanaka3 opened this issue Feb 8, 2023 · 4 comments
Closed
3 tasks done

fix: typo and expired link #2841

taikitanaka3 opened this issue Feb 8, 2023 · 4 comments
Assignees
@HansRobo
Labels
status:help-wanted Assistance or contributors needed. type:bug Software flaws or errors.

Comments

@taikitanaka3
Copy link
Contributor

Checklist

  • I've read the contribution guidelines.
  • I've searched other issues and no duplicate issues were found.
  • I've agreed with the maintainers that I can plan this task.

Description

There are many expired links and typos for example
#2216

Purpose

To eliminate typos and expired link to pass CI test

Possible approaches

Fix readme and codes.

Definition of done

pre-commit optional and spell check
https://github.com/autowarefoundation/autoware.universe/actions/workflows/pre-commit-optional.yaml
https://github.com/autowarefoundation/autoware.universe/actions/workflows/spell-check-differential.yaml
@taikitanaka3 taikitanaka3 added the status:help-wanted Assistance or contributors needed. label Feb 8, 2023
@HansRobo HansRobo mentioned this issue Feb 8, 2023
Merged
4 tasks
@HansRobo
Copy link
Member

HansRobo commented Feb 8, 2023

I started to fix links in #2842!

@HansRobo
Copy link
Member

HansRobo commented Feb 8, 2023

I found that pre-commit-optional is failed when no link errors are occured.
#2842 (comment)

So, we need to debug and fix in another PR.

@BonoloAWF BonoloAWF added the type:bug Software flaws or errors. label Feb 16, 2023
@HansRobo HansRobo mentioned this issue Mar 3, 2023
Merged
4 tasks
@mitsudome-r
Copy link
Member

@HansRobo @taikitanaka3 Do you still have other action items for this issue?

@taikitanaka3
Copy link
Contributor Author

taikitanaka3 commented Mar 14, 2023 •
edited
Loading

@HansRobo
I think this is issue done. what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HansRobo HansRobo

Labels
status:help-wanted Assistance or contributors needed. type:bug Software flaws or errors.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@HansRobo @mitsudome-r @taikitanaka3 @BonoloAWF