Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(obstacle_avoidance_planner): fix drivable area polygon point order direction #2691

Conversation

mehmetdogru
Copy link
Contributor

Signed-off-by: Mehmet Dogru 42mehmetdogru42@gmail.com

Description

closes #2690

This PR fixes the direction of drivable area polygon points since it can yield wrong results to use the polygon in other boost functions. (please refer)

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…r direction

Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com>
@mehmetdogru mehmetdogru added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 19, 2023
@mehmetdogru mehmetdogru added this to the Bus ODD Jan-Feb Milestone milestone Jan 19, 2023
@mehmetdogru mehmetdogru requested review from kosuke55, takayuki5168 and a team as code owners January 19, 2023 00:01
@mehmetdogru mehmetdogru self-assigned this Jan 19, 2023
@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Base: 11.38% // Head: 11.33% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (73d0ba4) compared to base (d15141e).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2691      +/-   ##
==========================================
- Coverage   11.38%   11.33%   -0.05%     
==========================================
  Files        1277     1277              
  Lines       89240    89623     +383     
  Branches    23628    23946     +318     
==========================================
+ Hits        10158    10159       +1     
- Misses      68310    68652     +342     
- Partials    10772    10812      +40     
Flag Coverage Δ *Carryforward flag
differential 17.48% <0.00%> (?)
total 11.38% <0.00%> (ø) Carriedforward from d15141e

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
planning/obstacle_avoidance_planner/src/node.cpp 0.17% <0.00%> (+0.04%) ⬆️
...ing/obstacle_avoidance_planner/src/utils/utils.cpp 10.38% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mehmetdogru mehmetdogru merged commit 2edacb6 into autowarefoundation:main Jan 25, 2023
@mehmetdogru mehmetdogru deleted the 2690/obstacle_avoidance_planner/fix-drivable-area-polygon-point-order-direction branch January 25, 2023 10:07
maxime-clem pushed a commit to maxime-clem/autoware.universe that referenced this pull request Jan 30, 2023
…r direction (autowarefoundation#2691)

Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com>

Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com>
lexavtanke pushed a commit to lexavtanke/autoware.universe that referenced this pull request Jan 31, 2023
…r direction (autowarefoundation#2691)

Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com>

Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com>
Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>
asana17 pushed a commit to asana17/autoware.universe that referenced this pull request Feb 8, 2023
…r direction (autowarefoundation#2691)

Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com>

Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com>
KYabuuchi pushed a commit to KYabuuchi/autoware.universe that referenced this pull request Feb 16, 2023
updates:
- [github.com/pre-commit/mirrors-prettier: v2.6.2 → v2.7.1](pre-commit/mirrors-prettier@v2.6.2...v2.7.1)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Correct point order of drivable area polygon
2 participants