Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(behavior_path_planner): pull over no stopping area #2492

Merged
merged 2 commits into from
Dec 22, 2022
Merged

feat(behavior_path_planner): pull over no stopping area #2492

merged 2 commits into from
Dec 22, 2022

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Dec 13, 2022 •
edited
Loading

Description

pull_over search goal candidates only in other than no_stopping_area.

pull_over_no_stopping-2022-12-13_14.35.51.mp4

Related links

Tests performed

psim, real vehicle

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added component:common Common packages from the autoware-common repository. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Dec 13, 2022
@kosuke55 kosuke55 force-pushed the feat/pull_over_no_stopping branch from d6305a0 to 60ebc60 Compare December 15, 2022 12:11
@github-actions github-actions bot removed the component:control Vehicle control algorithms and mechanisms. (auto-assigned) label Dec 15, 2022
@codecov
Copy link

codecov bot commented Dec 15, 2022 •
edited
Loading

Codecov Report

Base: 10.55% // Head: 10.43% // Decreases project coverage by -0.11% ⚠️

Coverage data is based on head (1c26078) compared to base (8bdfe7c).
Patch coverage: 2.13% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2492      +/-   ##
==========================================
- Coverage   10.55%   10.43%   -0.12%     
==========================================
  Files        1268     1268              
  Lines       87604    88723    +1119     
  Branches    20931    21674     +743     
==========================================
+ Hits         9246     9260      +14     
- Misses      68495    69556    +1061     
- Partials     9863     9907      +44
Flag Coverage Δ *Carryforward flag
differential 3.11% <0.00%> (?)
total 10.55% <3.75%> (ø) Carriedforward from 8bdfe7c

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
..._planner/scene_module/pull_out/pull_out_module.hpp 0.00% <ø> (ø)
...nner/scene_module/pull_out/pull_out_parameters.hpp 0.00% <ø> (ø)
...h_planner/scene_module/pull_out/shift_pull_out.hpp 0.00% <ø> (ø)
...nner/scene_module/pull_over/goal_searcher_base.hpp 0.00% <0.00%> (ø)
...lanner/scene_module/pull_over/pull_over_module.hpp 0.00% <ø> (ø)
...er/scene_module/pull_over/pull_over_parameters.hpp 0.00% <ø> (ø)
.../scene_module/pull_over/pull_over_planner_base.hpp 0.00% <ø> (ø)
...planner/scene_module/pull_over/shift_pull_over.hpp 0.00% <ø> (ø)
...lanner/include/behavior_path_planner/utilities.hpp 34.48% <ø> (+5.07%) ⬆️
...or_path_planner/src/behavior_path_planner_node.cpp 0.29% <0.00%> (+0.11%) ⬆️
... and 28 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kosuke55 kosuke55 force-pushed the feat/pull_over_no_stopping branch 3 times, most recently from 9361939 to 78633b6 Compare December 20, 2022 09:34
@kosuke55
feat(behavior_path_planner): pull over no stopping area
be269fe 
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 force-pushed the feat/pull_over_no_stopping branch from 78633b6 to be269fe Compare December 22, 2022 06:53
@github-actions github-actions bot removed component:launch Launch files, scripts and initialization tools. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Dec 22, 2022
@kosuke55 kosuke55 marked this pull request as ready for review December 22, 2022 06:54
@kosuke55
Copy link
Contributor Author

@rej55
Could you please review this also? 🙏

rej55
rej55 approved these changes Dec 22, 2022
View reviewed changes
Copy link
Contributor

@rej55 rej55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kosuke55 kosuke55 enabled auto-merge (squash) December 22, 2022 07:55
@kosuke55 kosuke55 merged commit 4600cf2 into autowarefoundation:main Dec 22, 2022
@kosuke55 kosuke55 deleted the feat/pull_over_no_stopping branch December 22, 2022 07:58
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Dec 23, 2022
Merged
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Dec 23, 2022
@kosuke55
feat(behavior_path_planner): pull over no stopping area (autowarefoun…
5e51317 
…dation#2492)

* feat(behavior_path_planner): pull over no stopping area

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* Update planning/behavior_path_planner/src/scene_module/pull_over/goal_searcher.cpp

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Dec 28, 2022
@kosuke55
feat(behavior_path_planner): pull over no stopping area (autowarefoun…
71eaca1 
…dation#2492)

* feat(behavior_path_planner): pull over no stopping area

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* Update planning/behavior_path_planner/src/scene_module/pull_over/goal_searcher.cpp

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 mentioned this pull request Dec 28, 2022
Merged
7 tasks
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Dec 28, 2022
@kosuke55
feat(behavior_path_planner): pull over no stopping area (autowarefoun…
42d1285 
…dation#2492)

* feat(behavior_path_planner): pull over no stopping area

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* Update planning/behavior_path_planner/src/scene_module/pull_over/goal_searcher.cpp

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Dec 28, 2022
@kosuke55
feat(behavior_path_planner): pull over no stopping area (#225)
8040584 
feat(behavior_path_planner): pull over no stopping area (autowarefoundation#2492)

* feat(behavior_path_planner): pull over no stopping area

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* Update planning/behavior_path_planner/src/scene_module/pull_over/goal_searcher.cpp

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jan 6, 2023
@kosuke55 @kminoda
feat(behavior_path_planner): pull over no stopping area (autowarefoun…
10eb8c8 
…dation#2492)

* feat(behavior_path_planner): pull over no stopping area

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* Update planning/behavior_path_planner/src/scene_module/pull_over/goal_searcher.cpp

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kosuke55 kosuke55 mentioned this pull request Apr 19, 2023
Merged
7 tasks
@kosuke55 kosuke55 mentioned this pull request Jul 31, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rej55 rej55 rej55 approved these changes

@satoshi-ota satoshi-ota Awaiting requested review from satoshi-ota

@shmpwk shmpwk Awaiting requested review from shmpwk

@taikitanaka3 taikitanaka3 Awaiting requested review from taikitanaka3

@TakaHoribe TakaHoribe Awaiting requested review from TakaHoribe

@takayuki5168 takayuki5168 Awaiting requested review from takayuki5168

@tkimura4 tkimura4 Awaiting requested review from tkimura4

@purewater0901 purewater0901 Awaiting requested review from purewater0901

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 Awaiting requested review from zulfaqar-azmi-t4

Assignees
No one assigned
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kosuke55 @rej55