Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_planner): pull over no stopping area #225

Merged
merged 1 commit into from
Dec 28, 2022

Conversation

kosuke55
Copy link

@kosuke55 kosuke55 commented Dec 28, 2022

Description

autowarefoundation#2492

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kosuke55
Copy link
Author

merge after #224

shmpwk
shmpwk previously approved these changes Dec 28, 2022
@tkimura4
Copy link
Collaborator

(コンフリクト解消したらそのままマージしちゃって大丈夫です。他のPRも。)

…dation#2492)

* feat(behavior_path_planner): pull over no stopping area

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* Update planning/behavior_path_planner/src/scene_module/pull_over/goal_searcher.cpp

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 force-pushed the feat/pull_over_no_stopping_area_v0.7 branch from 71eaca1 to 42d1285 Compare December 28, 2022 09:54
@github-actions github-actions bot removed common documentation Improvements or additions to documentation labels Dec 28, 2022
@kosuke55
Copy link
Author

@tkimura4
すみません、pushしなおすと、approve dismissされてしまうみたいです。
設定変えること可能でしょうか?:pray:

@tkimura4
Copy link
Collaborator

設定かえておきました。 

@kosuke55 kosuke55 changed the title feat(behavior_path_planner): pull over no stopping area feat(behavior_path_planner): pull over no stopping area Dec 28, 2022
@kosuke55 kosuke55 merged commit 8040584 into beta/v0.7.0 Dec 28, 2022
@kosuke55 kosuke55 deleted the feat/pull_over_no_stopping_area_v0.7 branch December 28, 2022 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants