-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(perception_utils): enable tracker to track smaller object by adapting min_union_area #2303
feat(perception_utils): enable tracker to track smaller object by adapting min_union_area #2303
Conversation
Signed-off-by: Yoshi Ri <yoshi.ri@tier4.jp>
Codecov ReportBase: 10.50% // Head: 10.51% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2303 +/- ##
==========================================
+ Coverage 10.50% 10.51% +0.01%
==========================================
Files 1248 1248
Lines 90626 90618 -8
Branches 20728 20715 -13
==========================================
+ Hits 9517 9528 +11
+ Misses 71016 70994 -22
- Partials 10093 10096 +3
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Yoshi Ri <yoshi.ri@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…pting min_union_area (autowarefoundation#2303) * update get2dIoU to recv min_union_area Signed-off-by: Yoshi Ri <yoshi.ri@tier4.jp> * declare the use of min_union_iou_area in tracker Signed-off-by: Yoshi Ri <yoshi.ri@tier4.jp> Signed-off-by: Yoshi Ri <yoshi.ri@tier4.jp> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
…pting min_union_area (autowarefoundation#2303) * update get2dIoU to recv min_union_area Signed-off-by: Yoshi Ri <yoshi.ri@tier4.jp> * declare the use of min_union_iou_area in tracker Signed-off-by: Yoshi Ri <yoshi.ri@tier4.jp> Signed-off-by: Yoshi Ri <yoshi.ri@tier4.jp> Signed-off-by: kminoda <koji.minoda@tier4.jp>
…pting min_union_area (autowarefoundation#2303) * update get2dIoU to recv min_union_area Signed-off-by: Yoshi Ri <yoshi.ri@tier4.jp> * declare the use of min_union_iou_area in tracker Signed-off-by: Yoshi Ri <yoshi.ri@tier4.jp> Signed-off-by: Yoshi Ri <yoshi.ri@tier4.jp> Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: Yoshi Ri yoshi.ri@tier4.jp
Description
Currently$0.01 m^2$ .
get2dIoU
function return zero iou when union_area is belowThis sometimes prevent tracking thin objects such as sign pole.
This PR makes the min_union_area threshold adjustable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.