Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(perception_utils): enable tracker to track smaller object by adapting min_union_area #2303

Conversation

YoshiRi
Copy link
Contributor

@YoshiRi YoshiRi commented Nov 16, 2022

Signed-off-by: Yoshi Ri yoshi.ri@tier4.jp

Description

Currently get2dIoU function return zero iou when union_area is below $0.01 m^2$.
This sometimes prevent tracking thin objects such as sign pole.

This PR makes the min_union_area threshold adjustable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Yoshi Ri <yoshi.ri@tier4.jp>
@YoshiRi YoshiRi requested a review from h-ohta November 16, 2022 10:55
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Nov 16, 2022
@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Base: 10.50% // Head: 10.51% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (b77df7e) compared to base (2572398).
Patch coverage: 20.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2303      +/-   ##
==========================================
+ Coverage   10.50%   10.51%   +0.01%     
==========================================
  Files        1248     1248              
  Lines       90626    90618       -8     
  Branches    20728    20715      -13     
==========================================
+ Hits         9517     9528      +11     
+ Misses      71016    70994      -22     
- Partials    10093    10096       +3     
Flag Coverage Δ *Carryforward flag
differential 6.21% <16.66%> (?)
total 10.48% <25.00%> (+<0.01%) ⬆️ Carriedforward from fdc77f0

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
..._tracker/src/data_association/data_association.cpp 0.00% <0.00%> (ø)
...i_object_tracker/src/multi_object_tracker_core.cpp 0.00% <0.00%> (ø)
...ation_merger/data_association/data_association.cpp 0.00% <0.00%> (ø)
...eption_utils/include/perception_utils/matching.hpp 69.49% <66.66%> (+6.44%) ⬆️
...planning_evaluator/src/planning_evaluator_node.cpp 37.11% <0.00%> (-1.04%) ⬇️
...erception/traffic_light_classifier/src/nodelet.cpp 0.00% <0.00%> (ø)
...est_node/include/fake_test_node/fake_test_node.hpp 39.13% <0.00%> (ø)
...c/pure_pursuit/pure_pursuit_lateral_controller.cpp 0.00% <0.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@yukke42 yukke42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@scepter914 scepter914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Yoshi Ri <yoshi.ri@tier4.jp>
@YoshiRi YoshiRi requested review from yukkysaito and a team as code owners November 18, 2022 06:16
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Nov 18, 2022
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YoshiRi YoshiRi enabled auto-merge (squash) November 18, 2022 06:21
@YoshiRi YoshiRi merged commit 3c0b335 into autowarefoundation:main Nov 18, 2022
HansRobo pushed a commit to HansRobo/autoware.universe that referenced this pull request Dec 16, 2022
…pting min_union_area (autowarefoundation#2303)

* update get2dIoU to recv min_union_area

Signed-off-by: Yoshi Ri <yoshi.ri@tier4.jp>

* declare the use of min_union_iou_area in tracker

Signed-off-by: Yoshi Ri <yoshi.ri@tier4.jp>

Signed-off-by: Yoshi Ri <yoshi.ri@tier4.jp>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jan 6, 2023
…pting min_union_area (autowarefoundation#2303)

* update get2dIoU to recv min_union_area

Signed-off-by: Yoshi Ri <yoshi.ri@tier4.jp>

* declare the use of min_union_iou_area in tracker

Signed-off-by: Yoshi Ri <yoshi.ri@tier4.jp>

Signed-off-by: Yoshi Ri <yoshi.ri@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
YoshiRi added a commit to YoshiRi/autoware.universe that referenced this pull request Jan 11, 2023
…pting min_union_area (autowarefoundation#2303)

* update get2dIoU to recv min_union_area

Signed-off-by: Yoshi Ri <yoshi.ri@tier4.jp>

* declare the use of min_union_iou_area in tracker

Signed-off-by: Yoshi Ri <yoshi.ri@tier4.jp>

Signed-off-by: Yoshi Ri <yoshi.ri@tier4.jp>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants