Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(trajectory_follower): simplify namespace format #1792

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Sep 6, 2022

Description

  • simplify namespace format
  • use autoware_utils for unit conversion rad2deg, etc.

Note: merge after #1791

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

❗ No coverage uploaded for pull request base (refactor/trajectory_follower_nodes@932128c). Click here to learn what that means.
The diff coverage is n/a.

@@                          Coverage Diff                          @@
##             refactor/trajectory_follower_nodes    #1792   +/-   ##
=====================================================================
  Coverage                                      ?   11.15%           
=====================================================================
  Files                                         ?     1212           
  Lines                                         ?    88449           
  Branches                                      ?    20979           
=====================================================================
  Hits                                          ?     9865           
  Misses                                        ?    68876           
  Partials                                      ?     9708           
Flag Coverage Δ *Carryforward flag
differential 42.65% <0.00%> (?)
total 10.37% <0.00%> (?) Carriedforward from 8c2080c

*This pull request uses carry forward flags. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@TakaHoribe TakaHoribe marked this pull request as ready for review September 19, 2022 02:02
@TakaHoribe TakaHoribe changed the title refact(trajectory_follower): cosmetic changes refactor(trajectory_follower): cosmetic changes Sep 19, 2022
@TakaHoribe TakaHoribe changed the title refactor(trajectory_follower): cosmetic changes refactor(trajectory_follower): simplify namespace format Sep 19, 2022
Copy link
Contributor

@taikitanaka3 taikitanaka3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM!

@TakaHoribe TakaHoribe merged commit d4e8ee7 into autowarefoundation:refactor/trajectory_follower_nodes Sep 19, 2022
@TakaHoribe TakaHoribe deleted the refactor/trajectory_follower_nodes branch September 19, 2022 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants