-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(trajectory_follower): use kinematic topic for ego pose #1791
feat(trajectory_follower): use kinematic topic for ego pose #1791
Conversation
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
3ff5023
to
a0fda5b
Compare
Codecov Report
@@ Coverage Diff @@
## main #1791 +/- ##
==========================================
+ Coverage 10.40% 10.75% +0.34%
==========================================
Files 1218 1218
Lines 87476 87858 +382
Branches 20479 20767 +288
==========================================
+ Hits 9106 9449 +343
+ Misses 68894 68859 -35
- Partials 9476 9550 +74
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
control/trajectory_follower/include/trajectory_follower/pid_longitudinal_controller.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…foundation#1791) * use constPtr Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * [velocity_controller] use topic for ego-pose, not TF Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * [mpc] use topic for ego-pose, not TF Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * rename prev variable Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
…foundation#1791) * use constPtr Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * [velocity_controller] use topic for ego-pose, not TF Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * [mpc] use topic for ego-pose, not TF Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * rename prev variable Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
…foundation#1791) * use constPtr Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * [velocity_controller] use topic for ego-pose, not TF Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * [mpc] use topic for ego-pose, not TF Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * rename prev variable Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
…foundation#1791) * use constPtr Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * [velocity_controller] use topic for ego-pose, not TF Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * [mpc] use topic for ego-pose, not TF Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * rename prev variable Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Description
For ego pose, replace TF with kinematic_state topic. As background, discussions on the localization interface resulted in the decision to use a topic instead of TF for ego pose information.
Related links
https://github.com/orgs/autowarefoundation/discussions/2594
Tests performed
Run in a planning simulator and checked if the controller tracked the trajectory.
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.