refactor(tier4_state_rviz_plugin): apply clang-tidy

[h-ohta]

Description

• fix clang-tidy
  • add const &
  • add initial value
  • fix boolean condition
• add NOLINT to avoid
  • readability-redundant-access-specifiers
• use using to shrink type definition

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

[codecov]

Codecov Report

Merging #1589 (e747467) into main (30ddff0) will decrease coverage by 0.41%.
The diff coverage is 0.00%.

❗ Current head e747467 differs from pull request most recent head 01d0a95. Consider uploading reports for the commit 01d0a95 to get more accurate results

@@            Coverage Diff             @@
##             main    #1589      +/-   ##
==========================================
- Coverage   10.77%   10.35%   -0.42%     
==========================================
  Files        1111     1135      +24     
  Lines       78532    79598    +1066     
  Branches    18561    18538      -23     
==========================================
- Hits         8459     8240     -219     
- Misses      61350    63154    +1804     
+ Partials     8723     8204     -519     

Flag	Coverage Δ		*Carryforward flag
differential	0.00% <0.00%> (?)
total	10.33% <0.00%> (-0.42%)	⬇️	Carriedforward from bb61357

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files	Coverage Δ
...er4_state_rviz_plugin/src/autoware_state_panel.cpp	0.00% <0.00%> (ø)
...vehicle_model/sim_model_ideal_steer_acc_geared.cpp	64.15% <0.00%> (-9.44%)	⬇️
...ocity_planner/src/utilization/path_utilization.cpp	12.96% <0.00%> (-5.96%)	⬇️
...ace_planning_algorithms/src/abstract_algorithm.cpp	77.92% <0.00%> (-2.08%)	⬇️
.../freespace_planning_algorithms/src/reeds_shepp.cpp	55.17% <0.00%> (-1.73%)	⬇️
...terpolation/test/src/test_spline_interpolation.cpp	27.81% <0.00%> (-0.89%)	⬇️
...ils/include/motion_utils/trajectory/trajectory.hpp	77.25% <0.00%> (-0.85%)	⬇️
...on/interpolation/test/src/test_zero_order_hold.cpp	31.81% <0.00%> (-0.62%)	⬇️
...tion_utils/test/src/trajectory/test_trajectory.cpp	25.05% <0.00%> (-0.55%)	⬇️
.../motion_velocity_smoother/src/trajectory_utils.cpp	2.73% <0.00%> (-0.51%)	⬇️
... and 162 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[kenji-miyake]

Cool!

[kenji-miyake]

@h-ohta By the way, refactor would be better because this PR won't change any behavior.