chore(clang-tidy): add SharedFuture in performance-unnecessary-value-param.AllowedTypes #2794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aram.AllowedTypes Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
h-ohta
force-pushed
the
feature/add_shared_furute
branch
from
cafc73a to
5bc2906
Compare
Merged
4 tasks
|
Since it's not a feature of this repository, please let me use |
kenji-miyake
changed the title
kenji-miyake
approved these changes
Aug 15, 2022
Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
h-ohta
force-pushed
the
feature/add_shared_furute
branch
from
0715986 to
50c6bb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Not to use NOLINT in autowarefoundation/autoware.universe#1589
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.