Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_velocity_planner, tier4_planning_launch): modify delay_resopnse_time #1557

Merged

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Aug 10, 2022

Signed-off-by: Takayuki Murooka takayuki5168@gmail.com

Description

delay_response_time in behavior velocity planner, which is the delay time for sensing and actuation, is too large for the usual vehicle model.

FYI
delay time of acceleration for sample_vehicle
https://github.com/autowarefoundation/sample_vehicle_launch/blob/95f0165c2636fe9b925a2b9e1becb55ae75a4177/sample_vehicle_description/config/simulator_model.param.yaml#L13

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 marked this pull request as ready for review August 10, 2022 04:56
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 changed the title fix(behavior_velocity_planner): modify delay_resopnse_time fix(behavior_velocity_planner, tier4_planning_launch): modify delay_resopnse_time Aug 10, 2022
@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #1557 (fcb462f) into main (6f75dad) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1557   +/-   ##
=======================================
  Coverage   10.74%   10.74%           
=======================================
  Files        1115     1115           
  Lines       78815    78815           
  Branches    18560    18560           
=======================================
  Hits         8465     8465           
  Misses      61492    61492           
  Partials     8858     8858           
Flag Coverage Δ *Carryforward flag
differential 4.69% <ø> (?)
total 10.72% <ø> (ø) Carriedforward from e68b3e0

*This pull request uses carry forward flags. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@TakaHoribe TakaHoribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Pls put a link to the vehicle model as evidence before merge.

@takayuki5168 takayuki5168 merged commit 319d15e into autowarefoundation:main Aug 15, 2022
@takayuki5168 takayuki5168 deleted the fix/behavior-vel-delay-time branch August 15, 2022 00:43
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
…esopnse_time (tier4#1557)

* fix(behavior_velocity_planner): modify delay_resopnse_time

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix(tier4_planning_launch): modify delay_resopnse_time

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
…esopnse_time (tier4#1557)

* fix(behavior_velocity_planner): modify delay_resopnse_time

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix(tier4_planning_launch): modify delay_resopnse_time

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
…esopnse_time (tier4#1557)

* fix(behavior_velocity_planner): modify delay_resopnse_time

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix(tier4_planning_launch): modify delay_resopnse_time

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
…esopnse_time (autowarefoundation#1557)

* fix(behavior_velocity_planner): modify delay_resopnse_time

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix(tier4_planning_launch): modify delay_resopnse_time

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
…esopnse_time (tier4#1557)

* fix(behavior_velocity_planner): modify delay_resopnse_time

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix(tier4_planning_launch): modify delay_resopnse_time

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
technolojin pushed a commit to technolojin/autoware.universe that referenced this pull request Oct 28, 2024
…ain-sync

chore: sync beta branch beta/v0.35 with tier4/main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants