-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(behavior_velocity_planner, tier4_planning_launch): modify delay_resopnse_time #1557
fix(behavior_velocity_planner, tier4_planning_launch): modify delay_resopnse_time #1557
Conversation
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #1557 +/- ##
=======================================
Coverage 10.74% 10.74%
=======================================
Files 1115 1115
Lines 78815 78815
Branches 18560 18560
=======================================
Hits 8465 8465
Misses 61492 61492
Partials 8858 8858
*This pull request uses carry forward flags. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Pls put a link to the vehicle model as evidence before merge.
…esopnse_time (tier4#1557) * fix(behavior_velocity_planner): modify delay_resopnse_time Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix(tier4_planning_launch): modify delay_resopnse_time Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…esopnse_time (tier4#1557) * fix(behavior_velocity_planner): modify delay_resopnse_time Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix(tier4_planning_launch): modify delay_resopnse_time Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…esopnse_time (tier4#1557) * fix(behavior_velocity_planner): modify delay_resopnse_time Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix(tier4_planning_launch): modify delay_resopnse_time Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…esopnse_time (autowarefoundation#1557) * fix(behavior_velocity_planner): modify delay_resopnse_time Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix(tier4_planning_launch): modify delay_resopnse_time Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…esopnse_time (tier4#1557) * fix(behavior_velocity_planner): modify delay_resopnse_time Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix(tier4_planning_launch): modify delay_resopnse_time Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…ain-sync chore: sync beta branch beta/v0.35 with tier4/main
Signed-off-by: Takayuki Murooka takayuki5168@gmail.com
Description
delay_response_time in behavior velocity planner, which is the delay time for sensing and actuation, is too large for the usual vehicle model.
FYI
delay time of acceleration for sample_vehicle
https://github.com/autowarefoundation/sample_vehicle_launch/blob/95f0165c2636fe9b925a2b9e1becb55ae75a4177/sample_vehicle_description/config/simulator_model.param.yaml#L13
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.