-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement sensor drivers for ROS 2 #551
Comments
* release v0.4.0 * fix uninitialized variables (autowarefoundation#816) * remove ROS1 packages temporarily Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Revert "remove ROS1 packages temporarily" This reverts commit 3a695e62c841e01681880263bb62a810f11ebf74. Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * add COLCON_IGNORE to ros1 packages Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Rename launch files to launch.xml (autowarefoundation#28) * port shape_estimation to ros2 (autowarefoundation#37) * port shape_estimation to ros2 Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * minor fix from review Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * remove unused files Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * minor fix on include Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * fix cmakelist Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * remove unused codes Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * fix cmake Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * [shape_estimation] fix launch file (autowarefoundation#116) * [shape_estimation] fix launch file Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * remove unnecessary find_package from CMakeLists.txt Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Adjust copyright notice on 532 out of 699 source files (autowarefoundation#143) * Use quotes for includes where appropriate (autowarefoundation#144) * Use quotes for includes where appropriate * Fix lint tests * Make tests pass hopefully * Run uncrustify on the entire Pilot.Auto codebase (autowarefoundation#151) * Run uncrustify on the entire Pilot.Auto codebase * Exclude open PRs * adding linters to shape_estimation (autowarefoundation#174) * Ros2 v0.8.0 shape estimation (autowarefoundation#257) * fix typos in perception (autowarefoundation#862) * Feature/camera lidar perception (autowarefoundation#937) * add object splitter Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com> * add object merger Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com> * change pkg name Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com> * cosmetic change Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com> * add comment Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com> * remove litter Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com> * bug fix : debug code Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com> * enable vehicle to unknown track Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com> * bug fix * add object position in clustering * 🚮 * change param * fix name * bug fix * add install Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com> * fix bug (autowarefoundation#1161) (autowarefoundation#374) Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com> * Fix typo in perception module (autowarefoundation#440) * add use_sim-time option (autowarefoundation#454) * Remove use_sim_time for set_parameter (autowarefoundation#1260) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Perception components (autowarefoundation#1368) * [bev_optical_flow]: component node Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [object_merger]: component node Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [object_range_splitter]: component node Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [shape_estimation]: component node Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [map_based_prediction]: component node Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [naive_path_prediction]: component node Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [roi_image_saver]: component node Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [lidar_apollo_instance_segmentation]: component node Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [object_flow_fusion]: component node Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [traffic_light_map_based_detector]: component node Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [dynamic_object_visualization]: component node Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fix typo Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Add markdownlint and prettier (autowarefoundation#1661) * Add markdownlint and prettier Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Ignore .param.yaml Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * suppress warnings for shape estimation (autowarefoundation#1770) * add Werror * fix uninitialized * Fix -Wunused-parameter (autowarefoundation#1836) * Fix -Wunused-parameter Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix mistake Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * fix spell * Fix lint issues Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Ignore flake8 warnings Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> * Refactor shape estimation for detection by tracking (autowarefoundation#1861) * refactor * modification due to refactoring * cosmetic change and add virtual * change to lib * fix typo * bug fix * cosmetic change * bug fix * add constexpr * cosmetic change * cosmetic change * cosmetic change * cosmetic change * Invoke code formatter at pre-commit (autowarefoundation#1935) * Run ament_uncrustify at pre-commit * Reformat existing files * Fix copyright and cpplint errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp> * add sort-package-xml hook in pre-commit (autowarefoundation#1881) * add sort xml hook in pre-commit * change retval to exit_status * rename * add prettier plugin-xml * use early return * add license note * add tier4 license * restore prettier * change license order * move local hooks to public repo * move prettier-xml to pre-commit-hooks-ros * update version for bug-fix * apply pre-commit * add createQuaternionFromYaw (autowarefoundation#2120) * add createQuaternionFromYaw * add test * change return value type of createQuaternionFromRPY from tf2::quat to geomety_msgs::msg::quat * use geometry_msgs::msg::Quaternion in createQuaternionFromRPY in application * Detection by tracker (autowarefoundation#1910) * initial commit * backup * apply format * cosmetic change * implement divided under segmenterd clusters * cosmetic change * bug fix * bug fix * bug fix * modify launch * add debug and bug fix * bug fix * bug fix * add no found tracked object * modify parameters and cmake * bug fix * remove debug info * add readme * modify clustering launch * run pre-commit * cosmetic change * cosmetic change * cosmetic change * apply markdownlint * modify launch * modify for cpplint * modify qos * change int to size_T * bug fix * change perception qos * Update perception/object_recognition/detection/detection_by_tracker/package.xml Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> * cosmetic change * cosmetic change * fix launch * Update perception/object_recognition/detection/detection_by_tracker/src/utils.cpp Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> * modify header include order * change include order * Update perception/object_recognition/detection/detection_by_tracker/src/detection_by_tracker_core.cpp Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> * change to std::optional * cosmetic change * Update perception/object_recognition/detection/detection_by_tracker/src/detection_by_tracker_core.cpp Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> * Update perception/object_recognition/detection/detection_by_tracker/src/detection_by_tracker_core.cpp Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> * bug fix * modify readme Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> * Change formatter to clang-format and black (autowarefoundation#2332) * Revert "Temporarily comment out pre-commit hooks" This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3. * Replace ament_lint_common with autoware_lint_common Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove ament_cmake_uncrustify and ament_clang_format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply Black Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply clang-format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix build errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix for cpplint * Fix include double quotes to angle brackets Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply clang-format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix build errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add COLCON_IGNORE (autowarefoundation#500) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Port shape estimation to .auto (autowarefoundation#551) * Port shape estimation to .auto Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Cosmetic change Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Cosmetic change Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Run pre commit Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fix typo Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Cosmetic change: type -> label Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Add trailer label Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Update document for shape estimation (autowarefoundation#604) * Update document for shape estimation Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Update perception/object_recognition/detection/shape_estimation/README.md Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * Run pre-commit Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Address review Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * [shape_estimation]change type (autowarefoundation#663) * change output type of shape_estimation * remove unused function * add dynamic_object_converter * rename * fix typo * fix dummy_perception_publisher * update readme * fix copyright * rename package * add readme * fix launch name * remove unused variable * fix readme * fix convert function * change topic name of DynamicObjectsWithFeature Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: Nikolai Morin <nnmmgit@gmail.com> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com> Co-authored-by: nik-tier4 <71747268+nik-tier4@users.noreply.github.com> Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com> Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> Co-authored-by: Takeshi Ishita <ishitah.takeshi@gmail.com> Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com> Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com> Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com>
Yang shared https://github.com/Kitware/LidarView, which might help us design a unified sensor driver for different LiDARs. |
@BonoloAWF
I didn't push anything. I only updated my forked repository. |
|
@mitsudome-r will check with ITRI about ROS2 drivers for their platform |
@hueirutseng what is the status update regarding upgrading ROS 2 drivers for the Bus ODD ITRI platform? Are there any missing drivers? |
@BonoloAWF The driver of camera AR0231 tested OK for ROS2. |
@jason914 Could you provide a similar table that @senagolcuk provided in his comment? ( including the link to the code of each driver) |
|
@jason914 Thanks for posting the table. |
|
Expected message for GNSS is explained here: autowarefoundation/autoware_msgs#24 |
Once we have all drivers available, we can merge the information with the list created in the hardware WG and post it in autoware website. |
@senagolcuk could you update here with the sensor drivers used in the ISUZU bus project? @meliketanrikulu can you share the estimated timeline for the open sourcing of the applanix driver? |
|
Applanix POS LVX GNSS-INS driver will be published here: https://github.com/autowarefoundation/applanix |
@senagolcuk |
I'm updating now. |
Added applanix POS LVX GNSS-INS driver. |
I have a question. Is it planned that OS1-64-ROS2 driver will be included in the Autoware.Universe like Velodyne drivers are? I see OS1-64 in the comment above, but cannot find a PR regarding that. |
@mikechan0731 Could you update this comment to add the link to the drivers that you are using? |
@meliketanrikulu thanks for Applanix Driver. I'm updating the table for the new driver. |
|
@senagolcuk could you update the list with the https://github.com/autowarefoundation/lucid_vision_driver driver? |
@xmfcx I updated it. |
Regarding ITRI's comment: #551 (comment) |
Since we've gathered possible sensor drivers, we can close this issue. |
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Signed-off-by: GitHub <noreply@github.com> Signed-off-by: GitHub <noreply@github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>
Checklist
Description
Implement sensor drivers for ROS 2
Purpose
The Bus ODD is being developed in ROS 2 which requires porting sensor drivers where required
Possible approaches
Find open source sensor drivers or implement the required drivers
Definition of done
ITRI Bus
Drivers post: #551 (comment)
Leo Drive - Isuzu Bus
Drivers post: #551 (comment)
The text was updated successfully, but these errors were encountered: