chore: Get release's version if needed #37777
Conversation
WalkthroughThe Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
github-actions
bot
added
the
skip-changelog
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
app/client/start-https.sh(1 hunks)
🔇 Additional comments (1)
app/client/start-https.sh (1)
89-95: Verify APPSMITH_VERSION_ID usage
Let's ensure this version ID is being used correctly throughout the application.
✅ Verification successful
APPSMITH_VERSION_ID changes are properly integrated
The version ID is correctly used across the application for version tracking and display:
- Used in index.html for client-side version information
- Properly configured in nginx for environment substitution
- Integrated with Caddy server configuration
- Correctly set up in Jest testing environment
The changes in start-https.sh are consistent with the existing version ID usage pattern across the codebase, and no other scripts are attempting to export this variable.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Search for APPSMITH_VERSION_ID usage
echo "Searching for APPSMITH_VERSION_ID usage in the codebase..."
rg "APPSMITH_VERSION_ID" -l
# Check if any other scripts are setting this variable
echo "Checking for other scripts setting APPSMITH_VERSION_ID..."
rg "export APPSMITH_VERSION_ID" -l
Length of output: 527
Script:
#!/bin/bash
# Let's check how APPSMITH_VERSION_ID is being used in these files
echo "=== Usage in index.html ==="
rg "APPSMITH_VERSION_ID" app/client/public/index.html -C 2
echo "=== Usage in nginx config ==="
rg "APPSMITH_VERSION_ID" app/client/docker/templates/nginx-app.conf.template -C 2
echo "=== Usage in caddy reconfigure ==="
rg "APPSMITH_VERSION_ID" deploy/docker/fs/opt/appsmith/caddy-reconfigure.mjs -C 2
echo "=== Usage in jest config ==="
rg "APPSMITH_VERSION_ID" app/client/jest.config.js -C 2
Length of output: 1642
**/test sanity** <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced script to retrieve and export the Appsmith application version when using a specific release URL. - **Bug Fixes** - Improved error handling and messaging for missing dependencies or incorrect configurations. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
/test sanity
Summary by CodeRabbit