chore: Always get version from $backend

[sharat87]

Automation

/ok-to-test tags=""

🔍 Cypress test results

Warning

Tests have not run on the HEAD 0ce2dfa yet

---

Fri, 29 Nov 2024 10:20:32 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• New Features

  • Enhanced functionality for starting HTTPS with improved error handling.
  • Generalized approach for retrieving the Appsmith version from the backend URL.

• Bug Fixes

  • Improved error messages for missing environment files.
  • Streamlined logic for determining the running environment.

• Chores

  • Updated NGINX configuration for better handling of HTTP and HTTPS requests.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces modifications to the start-https.sh script to improve its functionality and error handling. Key changes include a new method for retrieving the APPSMITH_VERSION_ID, enhanced checks for the existence of the env_file, and refined logic for the use_https variable. The script now defaults to HTTPS when mkcert is available and includes better identification of the running environment, ensuring proper handling of HTTP and HTTPS requests with updated NGINX configuration.

Changes

File	Change Summary
app/client/start-https.sh	- Updated method for retrieving APPSMITH_VERSION_ID from backend URL. - Improved error handling for env_file existence check. - Refined logic for use_https variable, defaulting to HTTPS if mkcert is available. - Streamlined environment detection for Docker or NGINX. - Updated NGINX configuration for handling HTTP and HTTPS requests.

Possibly related PRs

• chore: Get release's version if needed #37777: This PR modifies the same script start-https.sh to enhance version retrieval functionality, which is closely related to the changes made in the main PR regarding how APPSMITH_VERSION_ID is retrieved.

Suggested reviewers

• trishaanand
• mohanarpit
• nidhi-nair

🎉 In the land of scripts where the code does flow,
start-https.sh shines with a new glow.
With error checks and HTTPS in tow,
It dances with Docker, puts on a show!
So raise a cheer for this coding spree,
Robust and ready, as it should be! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.