chore: Don't need wget anymore
#37667
Conversation
WalkthroughThe pull request modifies the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
github-actions
bot
added
the
skip-changelog
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
deploy/docker/base.dockerfile (2)
Line range hint
41-44: Add checksum verification for downloadsWhile Node.js downloads include SHA256 verification, other curl downloads lack checksum verification. Consider adding similar verification for Java and Caddy downloads.
Example implementation:
&& version="17.0.9+9" \ + && curl -LOsS "https://github.com/adoptium/temurin17-binaries/releases/download/jdk-$version/OpenJDK17U-jdk_$(uname -m | sed s/x86_64/x64/)_linux_hotspot_$(echo $version | tr + _).tar.gz.sha256.txt" \ && curl --location "https://github.com/adoptium/temurin17-binaries/releases/download/jdk-$version/OpenJDK17U-jdk_$(uname -m | sed s/x86_64/x64/)_linux_hotspot_$(echo $version | tr + _).tar.gz" \ + | tee jdk.tar.gz | sha256sum -c jdk.tar.gz.sha256.txt \ - | tar -xz -C /opt/java --strip-components 1 + && tar -xzf jdk.tar.gz -C /opt/java --strip-components 1 \ + && rm jdk.tar.gz jdk.tar.gz.sha256.txt
Line range hint
19-30: Consider optimizing layer cachingThe package installation steps could be optimized for better layer caching. Consider combining related operations into single RUN instructions while keeping logical grouping.
Example restructuring:
RUN set -o xtrace \ && apt-get update \ && apt-get upgrade --yes \ && DEBIAN_FRONTEND=noninteractive apt-get install --no-install-recommends --yes \ supervisor curl nfs-common gnupg \ gettext \ ca-certificates \ + && curl --silent --show-error --location https://www.mongodb.org/static/pgp/server-5.0.asc | apt-key add - \ + && curl --silent --show-error --location https://www.postgresql.org/media/keys/ACCC4CF8.asc | apt-key add - \ + && echo "deb [ arch=amd64,arm64 ] https://repo.mongodb.org/apt/ubuntu focal/mongodb-org/5.0 multiverse" | tee /etc/apt/sources.list.d/mongodb-org-5.0.list \ + && echo "deb http://apt.postgresql.org/pub/repos/apt $(grep CODENAME /etc/lsb-release | cut -d= -f2)-pgdg main" | tee /etc/apt/sources.list.d/pgdg.list \ + && apt-get update \ + && apt-get install --no-install-recommends --yes mongodb-org redis postgresql-14 \ + && apt-get clean \ + && rm -rf /var/lib/apt/lists/*
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
deploy/docker/base.dockerfile(1 hunks)
🔇 Additional comments (2)
deploy/docker/base.dockerfile (2)
21-23: LGTM: Package changes align with requirements
The replacement of wget with curl is appropriate, and the additional packages are properly specified with minimal installation flags.
Let's verify no remaining wget dependencies:
Line range hint 30-30: Verify PostgreSQL upgrade impact
The upgrade from PostgreSQL 13 to 14 is a major version change. While the installation change is correct, we should ensure proper migration handling.
Let's check for PostgreSQL-specific configurations:
Also applies to: 32-32
We don't use
wget, justcurlin all places.Tested with full suite on EE.
Automation
/test sanity
🔍 Cypress test results
Caution
If you modify the content in this section, you are likely to disrupt the CI result for your PR.
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit
wgetfrom the package installation command, streamlining the setup.