chore: Handle changed NodeJS download links

[sharat87]

NodeJS have slightly changed the way they publish their artifacts and the way we download isn't working anymore. This PR fixes that.

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• Chores
  • Updated environment variable formatting for clarity and conciseness.
  • Enhanced the NodeJS installation process for improved integrity verification.
  • Maintained existing structure and dependencies within the Dockerfile.

/test sanity

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/11833162543
Commit: 4aa1ca2
Cypress dashboard.
Tags: @tag.Sanity
Spec:

---

Thu, 14 Nov 2024 08:42:02 UTC

[coderabbitai]

Walkthrough

The changes in this pull request focus on enhancements to the Dockerfile, specifically improving the installation process and error handling for NodeJS. The environment variable declarations for LANG and LC_ALL have been reformatted. The NodeJS installation method has been updated to include downloading a checksum file for tarball integrity verification, capturing architecture details, and cleaning up temporary files post-installation. The overall structure, including other dependencies like MongoDB and Redis, remains unchanged.

Changes

File	Change Summary
deploy/docker/base.dockerfile	Reformatted LANG and LC_ALL environment variables; enhanced NodeJS installation logic with checksum verification and architecture handling; removed temporary files post-installation.

Possibly related PRs

• chore: Install latest NodeJS again #33700: This PR updates the NodeJS installation process in the Dockerfile, which is directly related to the changes made in the main PR regarding the NodeJS installation logic.
• chore: Fix condition syntax in Dockerfile #37270: This PR addresses a syntax issue in the Dockerfile, which is relevant as the main PR also involves modifications to the Dockerfile, specifically in the installation process and error handling.

Suggested labels

ok-to-test

Suggested reviewers

• pratapaprasanna
• mohanarpit
• abhvsn

🎉 In the Dockerfile, changes abound,
Environment variables neatly found.
From file to path, a clear renaming,
With concise formats, the code's reclaiming.
Dependencies still flow, all in a row,
A leaner image, ready to go! 🚀

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between a0061b3 and 4aa1ca2.

📒 Files selected for processing (1)

• deploy/docker/base.dockerfile (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• deploy/docker/base.dockerfile

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 5af1bbe and a0061b3.

📒 Files selected for processing (1)

• deploy/docker/base.dockerfile (2 hunks)

🔇 Additional comments (1)

deploy/docker/base.dockerfile (1)

13-14: LGTM! Clean formatting change.

The environment variable declaration format is more concise while maintaining the same functionality.