Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Find version after backend is ready #37861

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

sharat87
Copy link
Member

@sharat87 sharat87 commented Nov 29, 2024

Automation

/ok-to-test tags=""

🔍 Cypress test results

Caution

If you modify the content in this section, you are likely to disrupt the CI result for your PR.

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • New Features

    • Enhanced error handling for the environment configuration.
    • Added safeguards for backend variable checks.
  • Bug Fixes

    • Improved robustness of the script to prevent execution errors when backend is not specified.
  • Documentation

    • Added verbose output for better debugging context during execution.

Copy link
Contributor

coderabbitai bot commented Nov 29, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The start-https.sh script has been updated to improve functionality and error handling. Key changes include a new conditional for fetching APPSMITH_VERSION_ID only if the backend variable is set, enhanced error messaging for the env_file, and adjustments to the logic determining the use of HTTPS. The curl command now includes a -v flag for verbose output, aiding debugging. Overall, these modifications enhance the script's robustness and error management.

Changes

File Change Summary
app/client/start-https.sh - Added conditional block for fetching APPSMITH_VERSION_ID based on backend variable.
- Modified curl command to include -v flag for verbose output.
- Refined error handling for env_file, providing clearer messages if inaccessible.
- Adjusted logic for HTTPS usage, defaulting to HTTP if neither HTTPS nor mkcert is available.

Possibly related PRs

  • chore: Get release's version if needed #37777: This PR modifies the same script start-https.sh to add functionality for retrieving the Appsmith version, which is closely related to the changes made in the main PR that also involves modifications to the APPSMITH_VERSION_ID variable in the same script.

Suggested labels

ok-to-test

Suggested reviewers

  • nidhi-nair
  • trishaanand
  • mohanarpit

🌟 In the script where the HTTPS flows,
A check for the backend now grows.
With curl's verbose, errors are tamed,
And clearer messages are now proclaimed.
Robustness shines, as logic aligns,
In the land of code, where the best design shines! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Nov 29, 2024
@sharat87 sharat87 marked this pull request as ready for review November 29, 2024 13:27
@sharat87 sharat87 merged commit 362b726 into release Nov 29, 2024
14 of 15 checks passed
@sharat87 sharat87 deleted the chore/fix-start-http-again branch November 29, 2024 13:27
github-actions bot pushed a commit to Zeral-Zhang/appsmith that referenced this pull request Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Adding this label to a PR prevents it from being listed in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant