Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proxy protocol out fixes #9341

Merged
merged 4 commits into from
Jan 31, 2023
Merged

Proxy protocol out fixes #9341

merged 4 commits into from
Jan 31, 2023

Conversation

bneradt
Copy link
Contributor

@bneradt bneradt commented Jan 31, 2023 •
edited
Loading

This fixes the following 2 issues with proxy.config.http.proxy_protocol_out:

  1. The Proxy Protocol string had src and dest reversed Proxy Protocol strings have dest and src reversed #9335
  2. Proxy Protocol strings weren't sent with a blind tunnel

@bneradt bneradt added this to the 10.0.0 milestone Jan 31, 2023
@bneradt bneradt self-assigned this Jan 31, 2023
masaori335
masaori335 approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@masaori335 masaori335 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! AuTest for outbound proxy protocol seems great!

@bneradt bneradt merged commit c5b9bd4 into apache:master Jan 31, 2023
@bneradt bneradt deleted the proxy_protocol_out_fixes branch January 31, 2023 17:04
cmcfarlen pushed a commit to cmcfarlen/trafficserver that referenced this pull request Jun 3, 2024
@zwoop
Merge remote-tracking branch 'asf/master'
bb70c30 
* asf/master: (623 commits)
  records.config to records.yaml (apache#9264)
  Updates the release roadmap, adjusting for delays (apache#9360)
  Upgrades master branch to use clang-format v15.0.7 (apache#9355)
  Disable merging on GitHub (apache#9354)
  Clang-format 15.0.7 is finicky, and does not like these old school array inits (apache#9356)
  Enable merging for 10-Dev merge (apache#9353)
  Fix an error on SSL config reload (plus some cleanup). (apache#9334)
  Cleanup of legacy, makes newer clang-format crash right now (apache#9350)
  Update the roadmap / branch management doc page (apache#9340)
  Proxy Protocol out fixes (apache#9341)
  Memory leaks with storing configuration filenames (apache#9324)
  s3_auth autest: convert from gold file to file contains (apache#9337)
  Make 204 cacheable again (apache#9333)
  Add param to forward headers from the auth server to the origin (apache#9271)
  s3_auth: Fix assertion failure of TSActionCancel (apache#9329)
  Added http connect Autest with proxy verifier (apache#9315)
  s3_auth: Schedule reloading config event on TASK thread (apache#9328)
  Register ET_UDP thread type even if no UDP threads are requested (apache#9314)
  Don't send response body on status 204 No Content (apache#9330)
  Limit the serching range of static table by the first letter of header name (apache#9298)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masaori335 masaori335 masaori335 approved these changes

Assignees

@bneradt bneradt

Labels
PROXY Protocol
Projects
None yet
Milestone
10.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bneradt @masaori335