Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add param to forward headers from the auth server to the origin #9271

Merged
merged 1 commit into from
Jan 25, 2023

Conversation

Ftywan
Copy link
Contributor

@Ftywan Ftywan commented Dec 21, 2022

Added a header prefix field to the config. Headers from the authentication response with the prefix will be appended to the original request.

new parameter: @pparam=--forward-header-prefix

@Ftywan Ftywan force-pushed the auth-proxy-header-forward branch 2 times, most recently from aebcb08 to 446c95a Compare December 21, 2022 08:00
@Ftywan Ftywan marked this pull request as ready for review December 21, 2022 08:01
@masaori335 masaori335 added this to the 10.0.0 milestone Dec 21, 2022
@masaori335
Copy link
Contributor

[approve ci]

@mlibbey
Copy link
Contributor

mlibbey commented Dec 22, 2022

Can we add this option to the documentation? Will all headers that match the prefix that come back from the auth server be proxied to the origin? What's the format of the value (just text)? Is there just one prefix that can be configured? (think the doc is at doc/admin-guide/plugins/authproxy.en.rst)

@Ftywan Ftywan force-pushed the auth-proxy-header-forward branch from 446c95a to b93ee5d Compare December 29, 2022 07:51
@Ftywan
Copy link
Contributor Author

Ftywan commented Dec 29, 2022

Hey @mlibbey, I've added the option usage to the documentation.
Regarding the queries, only one prefix can be configured in the form of plain text. All matching headers from the authentication server will be proxied to the origin.

@Ftywan Ftywan force-pushed the auth-proxy-header-forward branch 2 times, most recently from a94f7bb to 7fb41e4 Compare December 29, 2022 09:36
@Ftywan Ftywan force-pushed the auth-proxy-header-forward branch from 7fb41e4 to f57e897 Compare December 29, 2022 09:38
@bryancall bryancall self-requested a review January 10, 2023 00:16
@masaori335 masaori335 merged commit b7b25f7 into apache:master Jan 25, 2023
masaori335 added a commit to masaori335/trafficserver that referenced this pull request Jul 24, 2023
…he#9271) (apache#482)

(cherry picked from commit b7b25f7)

Co-authored-by: Fu Tianyuan <ftygary@gmail.com>
cmcfarlen pushed a commit to cmcfarlen/trafficserver that referenced this pull request Jun 3, 2024
* asf/master: (623 commits)
  records.config to records.yaml (apache#9264)
  Updates the release roadmap, adjusting for delays (apache#9360)
  Upgrades master branch to use clang-format v15.0.7 (apache#9355)
  Disable merging on GitHub (apache#9354)
  Clang-format 15.0.7 is finicky, and does not like these old school array inits (apache#9356)
  Enable merging for 10-Dev merge (apache#9353)
  Fix an error on SSL config reload (plus some cleanup). (apache#9334)
  Cleanup of legacy, makes newer clang-format crash right now (apache#9350)
  Update the roadmap / branch management doc page (apache#9340)
  Proxy Protocol out fixes (apache#9341)
  Memory leaks with storing configuration filenames (apache#9324)
  s3_auth autest: convert from gold file to file contains (apache#9337)
  Make 204 cacheable again (apache#9333)
  Add param to forward headers from the auth server to the origin (apache#9271)
  s3_auth: Fix assertion failure of TSActionCancel (apache#9329)
  Added http connect Autest with proxy verifier (apache#9315)
  s3_auth: Schedule reloading config event on TASK thread (apache#9328)
  Register ET_UDP thread type even if no UDP threads are requested (apache#9314)
  Don't send response body on status 204 No Content (apache#9330)
  Limit the serching range of static table by the first letter of header name (apache#9298)
  ...
@maskit maskit mentioned this pull request Aug 15, 2024
91 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants