Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s3_auth: Schedule reloading config event on TASK thread #9328

Merged
merged 1 commit into from
Jan 25, 2023

Conversation

masaori335
Copy link
Contributor

@masaori335 masaori335 commented Jan 23, 2023

The conf reload event of the s3_auth plugin is scheduled on the NET thread. The TASK thread is the appropriate thread to reload configs.

@masaori335 masaori335 added this to the 10.0.0 milestone Jan 23, 2023
@masaori335 masaori335 requested a review from duke8253 January 23, 2023 07:13
@masaori335 masaori335 self-assigned this Jan 23, 2023
@masaori335
Copy link
Contributor Author

This is a minor fix, but I'd like to have this for 9.2.1 as part of fixing the s3_auth plugin.

@masaori335 masaori335 merged commit ab5077d into apache:master Jan 25, 2023
zwoop pushed a commit that referenced this pull request Jan 25, 2023
@zwoop
Copy link
Contributor

zwoop commented Jan 25, 2023

Cherry-picked to v9.2.x

@zwoop zwoop modified the milestones: 10.0.0, 9.2.1 Jan 25, 2023
masaori335 pushed a commit to masaori335/trafficserver that referenced this pull request Feb 21, 2023
* asf/9.2.x:
  Updated ChangeLog
  Add slice config to strip Range header for HEAD requests (apache#9238)
  s3_auth: Schedule reloading config event on TASK thread (apache#9328)
  Don't send response body on status 204 No Content (apache#9330)
cmcfarlen pushed a commit to cmcfarlen/trafficserver that referenced this pull request Jun 3, 2024
* asf/master: (623 commits)
  records.config to records.yaml (apache#9264)
  Updates the release roadmap, adjusting for delays (apache#9360)
  Upgrades master branch to use clang-format v15.0.7 (apache#9355)
  Disable merging on GitHub (apache#9354)
  Clang-format 15.0.7 is finicky, and does not like these old school array inits (apache#9356)
  Enable merging for 10-Dev merge (apache#9353)
  Fix an error on SSL config reload (plus some cleanup). (apache#9334)
  Cleanup of legacy, makes newer clang-format crash right now (apache#9350)
  Update the roadmap / branch management doc page (apache#9340)
  Proxy Protocol out fixes (apache#9341)
  Memory leaks with storing configuration filenames (apache#9324)
  s3_auth autest: convert from gold file to file contains (apache#9337)
  Make 204 cacheable again (apache#9333)
  Add param to forward headers from the auth server to the origin (apache#9271)
  s3_auth: Fix assertion failure of TSActionCancel (apache#9329)
  Added http connect Autest with proxy verifier (apache#9315)
  s3_auth: Schedule reloading config event on TASK thread (apache#9328)
  Register ET_UDP thread type even if no UDP threads are requested (apache#9314)
  Don't send response body on status 204 No Content (apache#9330)
  Limit the serching range of static table by the first letter of header name (apache#9298)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants