Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register ET_UDP thread type even if no UDP threads are requested #9314

Merged
merged 1 commit into from
Jan 24, 2023
Merged

Register ET_UDP thread type even if no UDP threads are requested #9314

merged 1 commit into from
Jan 24, 2023

Conversation

maskit
Copy link
Member

@maskit maskit commented Jan 17, 2023

ET_UDP has to have a valid value because it's used to check the number of threads for the type.

trafficserver/iocore/net/QUICPacketHandler.cc

Lines 214 to 220 in 1a58539

n = eventProcessor.thread_group[ET_UDP]._count;
for (i = 0; i < n; i++) {
NetAccept *a = (i < n - 1) ? clone() : this;
EThread *t = eventProcessor.thread_group[ET_UDP]._thread[i];
a->mutex = get_NetHandler(t)->mutex;
t->schedule_imm(a);
}

The way of registering event type is inconsistent in ATS. This follows what we do for ET_TASK.

@maskit
Register ET_UDP thread type even if no UDP threads are requested
84022d6 
ET_UDP has to have a valid value because it's used to check the number of threads for the type.
@maskit maskit added the QUIC label Jan 17, 2023
@maskit maskit added this to the 10.0.0 milestone Jan 17, 2023
@maskit maskit self-assigned this Jan 17, 2023
@maskit
Copy link
Member Author

maskit commented Jan 17, 2023

This fixes #5506.

@maskit maskit linked an issue Jan 17, 2023 that may be closed by this pull request
QUIC: Assert when udp_thread is 0 #5506
Open
@maskit maskit added the UDP label Jan 23, 2023
@maskit maskit merged commit d210db1 into apache:10-Dev Jan 24, 2023
cmcfarlen pushed a commit to cmcfarlen/trafficserver that referenced this pull request Jun 3, 2024
@zwoop
Merge remote-tracking branch 'asf/master'
bb70c30 
* asf/master: (623 commits)
  records.config to records.yaml (apache#9264)
  Updates the release roadmap, adjusting for delays (apache#9360)
  Upgrades master branch to use clang-format v15.0.7 (apache#9355)
  Disable merging on GitHub (apache#9354)
  Clang-format 15.0.7 is finicky, and does not like these old school array inits (apache#9356)
  Enable merging for 10-Dev merge (apache#9353)
  Fix an error on SSL config reload (plus some cleanup). (apache#9334)
  Cleanup of legacy, makes newer clang-format crash right now (apache#9350)
  Update the roadmap / branch management doc page (apache#9340)
  Proxy Protocol out fixes (apache#9341)
  Memory leaks with storing configuration filenames (apache#9324)
  s3_auth autest: convert from gold file to file contains (apache#9337)
  Make 204 cacheable again (apache#9333)
  Add param to forward headers from the auth server to the origin (apache#9271)
  s3_auth: Fix assertion failure of TSActionCancel (apache#9329)
  Added http connect Autest with proxy verifier (apache#9315)
  s3_auth: Schedule reloading config event on TASK thread (apache#9328)
  Register ET_UDP thread type even if no UDP threads are requested (apache#9314)
  Don't send response body on status 204 No Content (apache#9330)
  Limit the serching range of static table by the first letter of header name (apache#9298)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SolidWallOfCode SolidWallOfCode SolidWallOfCode approved these changes

Assignees

@maskit maskit

Labels
QUIC UDP
Projects
None yet
Milestone
10.0.0
Development

Successfully merging this pull request may close these issues.

QUIC: Assert when udp_thread is 0
2 participants
@maskit @SolidWallOfCode