Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS watch icons generated without 44mm #657

Closed
3 tasks done
godexsoft opened this issue Aug 16, 2019 · 3 comments · Fixed by #1465
Closed
3 tasks done

iOS watch icons generated without 44mm #657

godexsoft opened this issue Aug 16, 2019 · 3 comments · Fixed by #1465
Milestone

Comments

@godexsoft
Copy link

godexsoft commented Aug 16, 2019

Bug Report

When i add my 100x100 icon for 44mm watch the icon is not used

Problem

If i want to support 44mm watch icon it appears to not be possible

What is expected to happen?

Icons in AppIcon.appiconset should be generated correctly with all watch icons covered

What does actually happen?

All watch icon slots are filled in but the 44mm one

Information

I don't actually need to have watch icons at all. just thought i would let you know it's broken

Command or Code

Environment, Platform, Device

macosx

Version information

cordova 9.0.1, cordova-ios 5.0.1

Checklist

  • I searched for existing GitHub issues
  • I updated all Cordova tooling to most recent version
  • I included all the necessary information above
@godexsoft
Copy link
Author

My bad. was actually referring to the 108x108 @x2 icon.. i was providing 100x100 looking in the wrong place. I now provide 216x216 icon but it still does not appear. It's the QuickLook icon for 44mm watch. If i inspect the generated AppIcon Contents.json the item is there but it got no filepath, hence it's empty in Xcode.

@dakotaJang
Copy link

It appears that this icon has not been configured at all.
I noticed that the icons get the default corodva icons when they are not configured but this 44mm 2x icon (216 x 216px) does not get any icon.
This part needs to be manually in Resources>Images.xcassets>AppIcon at the moment as far as I can tell.
image

@EinfachHans
Copy link

As you can see here the filename is missing for this, so it can't be set automatically. But i don't know why...

@dpogue dpogue linked a pull request Apr 16, 2023 that will close this issue
@dpogue dpogue added this to the 7.0.0 milestone Apr 16, 2023
@dpogue dpogue removed this from the 7.0.0 milestone Jun 6, 2023
@dpogue dpogue added this to the 8.0.0 milestone Aug 15, 2024
dpogue added a commit to dpogue/cordova-ios that referenced this issue Aug 17, 2024
Ironically, this also allows most people to drastically simplify their
icons by only providing a single 1024⨉1024 image with no special
attributes.

Closes apacheGH-592.
Closes apacheGH-623.
Closes apacheGH-657.
Closes apacheGH-658.
Closes apacheGH-1019.
Closes apacheGH-1233.
Closes apacheGH-1387.
dpogue added a commit to dpogue/cordova-ios that referenced this issue Aug 17, 2024
Ironically, this also allows most people to drastically simplify their
icons by only providing a single 1024⨉1024 image with no special
attributes.

Closes apacheGH-592.
Closes apacheGH-623.
Closes apacheGH-657.
Closes apacheGH-658.
Closes apacheGH-1019.
Closes apacheGH-1233.
Closes apacheGH-1387.
dpogue added a commit to dpogue/cordova-ios that referenced this issue Aug 18, 2024
Ironically, this also allows most people to drastically simplify their
icons by only providing a single 1024⨉1024 image with no special
attributes.

Closes apacheGH-592.
Closes apacheGH-623.
Closes apacheGH-657.
Closes apacheGH-658.
Closes apacheGH-1019.
Closes apacheGH-1233.
Closes apacheGH-1387.
dpogue added a commit to dpogue/cordova-ios that referenced this issue Aug 18, 2024
Ironically, this also allows most people to drastically simplify their
icons by only providing a single 1024⨉1024 image with no special
attributes.

Closes apacheGH-592.
Closes apacheGH-623.
Closes apacheGH-657.
Closes apacheGH-658.
Closes apacheGH-1019.
Closes apacheGH-1233.
Closes apacheGH-1387.
dpogue added a commit to dpogue/cordova-ios that referenced this issue Aug 18, 2024
Ironically, this also allows most people to drastically simplify their
icons by only providing a single 1024⨉1024 image with no special
attributes.

Closes apacheGH-592.
Closes apacheGH-623.
Closes apacheGH-657.
Closes apacheGH-658.
Closes apacheGH-1019.
Closes apacheGH-1233.
Closes apacheGH-1387.
dpogue added a commit to dpogue/cordova-ios that referenced this issue Aug 18, 2024
Ironically, this also allows most people to drastically simplify their
icons by only providing a single 1024⨉1024 image with no special
attributes.

Closes apacheGH-592.
Closes apacheGH-623.
Closes apacheGH-657.
Closes apacheGH-658.
Closes apacheGH-1019.
Closes apacheGH-1233.
Closes apacheGH-1387.
dpogue added a commit to dpogue/cordova-ios that referenced this issue Aug 20, 2024
Ironically, this also allows most people to drastically simplify their
icons by only providing a single 1024⨉1024 image with no special
attributes.

Closes apacheGH-592.
Closes apacheGH-623.
Closes apacheGH-657.
Closes apacheGH-658.
Closes apacheGH-1019.
Closes apacheGH-1233.
Closes apacheGH-1387.
dpogue added a commit to dpogue/cordova-ios that referenced this issue Aug 21, 2024
Ironically, this also allows most people to drastically simplify their
icons by only providing a single 1024⨉1024 image with no special
attributes.

Closes apacheGH-592.
Closes apacheGH-623.
Closes apacheGH-657.
Closes apacheGH-658.
Closes apacheGH-1019.
Closes apacheGH-1233.
Closes apacheGH-1387.
@dpogue dpogue closed this as completed in 3ce3a7e Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants