-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing/detached sizes for iOS app icons #48
Comments
Are you targeting the Apple Watch with Cordova? or maybe I'm misunderstanding something? |
I have an app built in Cordova which also has watch functionality. The generator appears to create all the other watch icons with the exception of these three. |
Oh, sure! I see. So, I'm confused as to why it's saying an icon is unassigned. We're generating a 44x44@2x icon:
|
Yeah, that’s odd. Don’t understand why that doesn’t get hooked up. I presume the other two aren’t being generated at all and probably need an update, but that one is odd. It happens every time the platform is removed and added, so it’s a consistently replicable pattern. I even tried removing all references to the icon from the config.xml and they were correctly regenerated, but with these same three problematic sizes. |
Okay, I'll mark it as a bug. I can't promise I'll get around to this in a timely manner--I have other priorities at the moment. If you like, this tool is easy enough to setup locally and work on. The icons are listed here: https://github.com/ionic-team/cordova-res/blob/master/src/resources.ts#L425 |
Ah ok, cool. Well thanks for the quick replies. I’ll maybe take a look and do a PR then. |
@WuglyakBolgoink Looks like it's not acknowledged by Cordova: apache/cordova-ios#657 |
I noticed when using cordova-res today that it generates 28 icons but not all of them are placed into the ios project. I wonder if this is the source of the configuration problem. The files that are generated into
Additionally, its not clear where the |
Fixed in |
When I add the iOS platform in my project, not all icons required are generated. From a clean project, I see the following when inspecting
images.xcassets
in Xcode 10.2 after cordova-res has been runAs you can see, the following sizes are missing;
and there is an unassigned image
The code which gets added to my config.xml is as follows;
What are we doing wrong, and is there a way to add the alternative sizes in ourselves via config.xml?
The text was updated successfully, but these errors were encountered: