Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all icons provided in config.xml are being used #1233

Closed
3 tasks done
Birowsky opened this issue May 2, 2022 · 0 comments · Fixed by #1465
Closed
3 tasks done

Not all icons provided in config.xml are being used #1233

Birowsky opened this issue May 2, 2022 · 0 comments · Fixed by #1465
Milestone

Comments

@Birowsky
Copy link

Birowsky commented May 2, 2022

Bug Report

Problem

Cordova doesn't utilize all icons provided in config.xml.

What is expected to happen?

Cordova should use all provided icons and adds them to XCode here:

Screen Shot 2022-05-02 at 1 13 04 PM

What does actually happen?

The icons that do not have Cordova placeholders do not get updated.

Information

I provide all icons sizes as described in the Cordova documentation here. I also provide icons sizes as described in XCode specs, that are outside of the cordova docs. Here's part of my config.xml:

...
<icon src="resources/ios/icon/icon-50.png" width="50" height="50" />
<icon src="resources/ios/icon/icon-50@2x.png" width="100" height="100" />
<icon src="resources/ios/icon/icon-83.5@2x.png" width="167" height="167" />
<icon src="resources/ios/icon/icon-1024.png" width="1024" height="1024" />
<icon src="resources/ios/icon/icon-20.png" width="20" height="20" />
<icon src="resources/ios/icon/icon-48.png" width="48" height="48" />
<icon src="resources/ios/icon/icon-55.png" width="55" height="55" />
<icon src="resources/ios/icon/icon-66.png" width="66" height="66" />
<icon src="resources/ios/icon/icon-88.png" width="88" height="88" />
<icon src="resources/ios/icon/icon-92.png" width="92" height="92" />
<icon src="resources/ios/icon/icon-102.png" width="102" height="102" />
<icon src="resources/ios/icon/icon-172.png" width="172" height="172" />
<icon src="resources/ios/icon/icon-196.png" width="196" height="196" />
...

With this approach, all icons get updated, except the ones that do not have templates by Cordova. A similar issue has been reported here, but I hope my description nicely generalizes it.

Checklist

  • I searched for existing GitHub issues
  • I updated all Cordova tooling to most recent version
  • I included all the necessary information above
@dpogue dpogue linked a pull request Apr 15, 2023 that will close this issue
@dpogue dpogue added this to the 8.0.0 milestone Aug 15, 2024
dpogue added a commit to dpogue/cordova-ios that referenced this issue Aug 17, 2024
Ironically, this also allows most people to drastically simplify their
icons by only providing a single 1024⨉1024 image with no special
attributes.

Closes apacheGH-592.
Closes apacheGH-623.
Closes apacheGH-657.
Closes apacheGH-658.
Closes apacheGH-1019.
Closes apacheGH-1233.
Closes apacheGH-1387.
dpogue added a commit to dpogue/cordova-ios that referenced this issue Aug 17, 2024
Ironically, this also allows most people to drastically simplify their
icons by only providing a single 1024⨉1024 image with no special
attributes.

Closes apacheGH-592.
Closes apacheGH-623.
Closes apacheGH-657.
Closes apacheGH-658.
Closes apacheGH-1019.
Closes apacheGH-1233.
Closes apacheGH-1387.
dpogue added a commit to dpogue/cordova-ios that referenced this issue Aug 18, 2024
Ironically, this also allows most people to drastically simplify their
icons by only providing a single 1024⨉1024 image with no special
attributes.

Closes apacheGH-592.
Closes apacheGH-623.
Closes apacheGH-657.
Closes apacheGH-658.
Closes apacheGH-1019.
Closes apacheGH-1233.
Closes apacheGH-1387.
dpogue added a commit to dpogue/cordova-ios that referenced this issue Aug 18, 2024
Ironically, this also allows most people to drastically simplify their
icons by only providing a single 1024⨉1024 image with no special
attributes.

Closes apacheGH-592.
Closes apacheGH-623.
Closes apacheGH-657.
Closes apacheGH-658.
Closes apacheGH-1019.
Closes apacheGH-1233.
Closes apacheGH-1387.
dpogue added a commit to dpogue/cordova-ios that referenced this issue Aug 18, 2024
Ironically, this also allows most people to drastically simplify their
icons by only providing a single 1024⨉1024 image with no special
attributes.

Closes apacheGH-592.
Closes apacheGH-623.
Closes apacheGH-657.
Closes apacheGH-658.
Closes apacheGH-1019.
Closes apacheGH-1233.
Closes apacheGH-1387.
dpogue added a commit to dpogue/cordova-ios that referenced this issue Aug 18, 2024
Ironically, this also allows most people to drastically simplify their
icons by only providing a single 1024⨉1024 image with no special
attributes.

Closes apacheGH-592.
Closes apacheGH-623.
Closes apacheGH-657.
Closes apacheGH-658.
Closes apacheGH-1019.
Closes apacheGH-1233.
Closes apacheGH-1387.
dpogue added a commit to dpogue/cordova-ios that referenced this issue Aug 20, 2024
Ironically, this also allows most people to drastically simplify their
icons by only providing a single 1024⨉1024 image with no special
attributes.

Closes apacheGH-592.
Closes apacheGH-623.
Closes apacheGH-657.
Closes apacheGH-658.
Closes apacheGH-1019.
Closes apacheGH-1233.
Closes apacheGH-1387.
dpogue added a commit to dpogue/cordova-ios that referenced this issue Aug 21, 2024
Ironically, this also allows most people to drastically simplify their
icons by only providing a single 1024⨉1024 image with no special
attributes.

Closes apacheGH-592.
Closes apacheGH-623.
Closes apacheGH-657.
Closes apacheGH-658.
Closes apacheGH-1019.
Closes apacheGH-1233.
Closes apacheGH-1387.
@dpogue dpogue closed this as completed in 3ce3a7e Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants