Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to configure icons for Catalyst #1387

Closed
3 tasks done
sbruens opened this issue Nov 22, 2023 · 0 comments · Fixed by #1465
Closed
3 tasks done

Unable to configure icons for Catalyst #1387

sbruens opened this issue Nov 22, 2023 · 0 comments · Fixed by #1465
Milestone
8.0.0

Comments

@sbruens
Copy link

sbruens commented Nov 22, 2023 •
edited
Loading

Bug Report

Problem

What is expected to happen?

I'm unable to configure macOS icons to build for Catalyst.

What does actually happen?

Missing icons for Catalyst builds.

Information

We have an iOS app to which we've added support for Mac Catalyst so we can deprecate our macOS app that was dependent on the deprecated cordova-osx. The iOS icon configuration isn't sufficient to cover the Catalyst/macOS icons; specifying the macOS icon sizes does nothing. I'd expect to be able to set macOS icons specified in config.xml, e.g.

<icon src="resources/icons/ios/Icon-24.png" width="24" height="24" />
<icon src="resources/icons/ios/Icon-24@2x.png" width="48" height="48" />

I appreciate this may be more of a FR instead of a bug, depending on current Catalyst support. I could attempt a PR as well.

Command or Code

Setup for Mac Catalyst and open in XCode and inspect the app icon in the Assets catalog.

Environment, Platform, Device

Mac Catalyst on macOS

Version information

Xcode: Version 15.0.1

Checklist

  • I searched for existing GitHub issues
  • I updated all Cordova tooling to most recent version
  • I included all the necessary information above
@sbruens sbruens mentioned this issue Nov 27, 2023
Merged
@dpogue dpogue added this to the 8.0.0 milestone Aug 15, 2024
dpogue added a commit to dpogue/cordova-ios that referenced this issue Aug 17, 2024
@dpogue
feat(icons): Allow a lot more control over icon assignment
3f6a54c 
Ironically, this also allows most people to drastically simplify their
icons by only providing a single 1024⨉1024 image with no special
attributes.

Closes apacheGH-592.
Closes apacheGH-623.
Closes apacheGH-657.
Closes apacheGH-658.
Closes apacheGH-1019.
Closes apacheGH-1233.
Closes apacheGH-1387.
dpogue added a commit to dpogue/cordova-ios that referenced this issue Aug 17, 2024
@dpogue
feat(icons): Allow a lot more control over icon assignment
6688e7d 
Ironically, this also allows most people to drastically simplify their
icons by only providing a single 1024⨉1024 image with no special
attributes.

Closes apacheGH-592.
Closes apacheGH-623.
Closes apacheGH-657.
Closes apacheGH-658.
Closes apacheGH-1019.
Closes apacheGH-1233.
Closes apacheGH-1387.
@dpogue dpogue mentioned this issue Aug 17, 2024
Merged
8 tasks
dpogue added a commit to dpogue/cordova-ios that referenced this issue Aug 18, 2024
@dpogue
feat(icons): Allow a lot more control over icon assignment
8fc533d 
Ironically, this also allows most people to drastically simplify their
icons by only providing a single 1024⨉1024 image with no special
attributes.

Closes apacheGH-592.
Closes apacheGH-623.
Closes apacheGH-657.
Closes apacheGH-658.
Closes apacheGH-1019.
Closes apacheGH-1233.
Closes apacheGH-1387.
dpogue added a commit to dpogue/cordova-ios that referenced this issue Aug 18, 2024
@dpogue
feat!(icons): Allow a lot more control over icon assignment
3ea57bf 
Ironically, this also allows most people to drastically simplify their
icons by only providing a single 1024⨉1024 image with no special
attributes.

Closes apacheGH-592.
Closes apacheGH-623.
Closes apacheGH-657.
Closes apacheGH-658.
Closes apacheGH-1019.
Closes apacheGH-1233.
Closes apacheGH-1387.
dpogue added a commit to dpogue/cordova-ios that referenced this issue Aug 18, 2024
@dpogue
feat!(icons): Allow a lot more control over icon assignment
ec95b10 
Ironically, this also allows most people to drastically simplify their
icons by only providing a single 1024⨉1024 image with no special
attributes.

Closes apacheGH-592.
Closes apacheGH-623.
Closes apacheGH-657.
Closes apacheGH-658.
Closes apacheGH-1019.
Closes apacheGH-1233.
Closes apacheGH-1387.
dpogue added a commit to dpogue/cordova-ios that referenced this issue Aug 18, 2024
@dpogue
feat!(icons): Allow a lot more control over icon assignment
8a04ef6 
Ironically, this also allows most people to drastically simplify their
icons by only providing a single 1024⨉1024 image with no special
attributes.

Closes apacheGH-592.
Closes apacheGH-623.
Closes apacheGH-657.
Closes apacheGH-658.
Closes apacheGH-1019.
Closes apacheGH-1233.
Closes apacheGH-1387.
dpogue added a commit to dpogue/cordova-ios that referenced this issue Aug 20, 2024
@dpogue
feat!(icons): Allow a lot more control over icon assignment
168eb8b 
Ironically, this also allows most people to drastically simplify their
icons by only providing a single 1024⨉1024 image with no special
attributes.

Closes apacheGH-592.
Closes apacheGH-623.
Closes apacheGH-657.
Closes apacheGH-658.
Closes apacheGH-1019.
Closes apacheGH-1233.
Closes apacheGH-1387.
dpogue added a commit to dpogue/cordova-ios that referenced this issue Aug 21, 2024
@dpogue
feat!(icons): Allow a lot more control over icon assignment
28cee54 
Ironically, this also allows most people to drastically simplify their
icons by only providing a single 1024⨉1024 image with no special
attributes.

Closes apacheGH-592.
Closes apacheGH-623.
Closes apacheGH-657.
Closes apacheGH-658.
Closes apacheGH-1019.
Closes apacheGH-1233.
Closes apacheGH-1387.
@dpogue dpogue closed this as completed in 3ce3a7e Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.0.0
2 participants
@dpogue @sbruens