Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: json serialization redundancy issue in store.py; closes #337; closes #300 #339

Merged
merged 1 commit into from
Mar 1, 2021

Conversation

bhavikapanara
Copy link
Contributor

Purpose

  • Resolve redundancy for JSON serialization in store.py file
  • Also addressed LGTM warnings for image_boundingBox_detection

Merge Checklist

  • The code change is tested and works locally.
  • The user and dev documentation is up to date.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

@commit-lint
Copy link

commit-lint bot commented Mar 1, 2021

Contributors

bhavikapanara

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@codecov
Copy link

codecov bot commented Mar 1, 2021

Codecov Report

Merging #339 (8e7ed00) into master (db4b00a) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #339      +/-   ##
==========================================
- Coverage   94.57%   94.56%   -0.01%     
==========================================
  Files          23       23              
  Lines        2232     2228       -4     
==========================================
- Hits         2111     2107       -4     
  Misses        121      121              
Impacted Files Coverage Δ
...mbianic/pipeline/ai/image_boundingBox_detection.py 100.00% <ø> (ø)
src/ambianic/pipeline/timeline.py 65.33% <ø> (-0.46%) ⬇️
src/ambianic/pipeline/store.py 98.97% <100.00%> (+0.01%) ⬆️

@lgtm-com
Copy link

lgtm-com bot commented Mar 1, 2021

This pull request fixes 4 alerts when merging 2108e06 into 263852e - view on LGTM.com

fixed alerts:

  • 4 for Unused import

Copy link
Collaborator

@ivelin ivelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bhavikapanara looks good. I'll wait for the CI to finish before merging.

@ivelin ivelin merged commit bb8d20a into ambianic:master Mar 1, 2021
github-actions bot pushed a commit that referenced this pull request Mar 1, 2021
## [1.14.6](v1.14.5...v1.14.6) (2021-03-01)

### Bug Fixes

* json serialization redundancy issue in store.py; closes [#337](#337); closes [#300](#300) ([bb8d20a](bb8d20a)), closes [#339](#339)
@github-actions
Copy link

github-actions bot commented Mar 1, 2021

🎉 This PR is included in version 1.14.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions bot pushed a commit to ivelin/ambianic-edge that referenced this pull request May 17, 2021
## [1.11.1](v1.11.0...v1.11.1) (2021-05-17)

### Bug Fixes

* build and publish python API docs ([2091c54](2091c54)), closes [ambianic#342](https://github.com/ivelin/ambianic-edge/issues/342)
* improve fall detection debug info ([7762752](7762752)), closes [ambianic#309](https://github.com/ivelin/ambianic-edge/issues/309)
* json serialization redundancy issue in store.py; closes [ambianic#337](https://github.com/ivelin/ambianic-edge/issues/337); closes [ambianic#300](https://github.com/ivelin/ambianic-edge/issues/300) ([bb8d20a](bb8d20a)), closes [ambianic#339](https://github.com/ivelin/ambianic-edge/issues/339)
* revert [ambianic#314](https://github.com/ivelin/ambianic-edge/issues/314); see [ambianic#330](https://github.com/ivelin/ambianic-edge/issues/330) for details; separate inference output formatting for each detection model; closes [ambianic#254](https://github.com/ivelin/ambianic-edge/issues/254)" ([ee79c40](ee79c40)), closes [ambianic#329](https://github.com/ivelin/ambianic-edge/issues/329)
* separate inference output formatting for each detection model; [issues [ambianic#330](https://github.com/ivelin/ambianic-edge/issues/330), [ambianic#254](https://github.com/ivelin/ambianic-edge/issues/254)] ([b83e4f8](b83e4f8)), closes [ambianic#332](https://github.com/ivelin/ambianic-edge/issues/332)
* separate inference output formatting for each detection model; closes [ambianic#254](https://github.com/ivelin/ambianic-edge/issues/254) ([8768c17](8768c17)), closes [ambianic#314](https://github.com/ivelin/ambianic-edge/issues/314)
* temporary solution to manage yaml.dump() encoding issue; closes [ambianic#330](https://github.com/ivelin/ambianic-edge/issues/330) ([db4b00a](db4b00a)), closes [ambianic#333](https://github.com/ivelin/ambianic-edge/issues/333)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants