fix: revert #314; see #330 for details; separate inference output formatting for each detection model; closes #254"

[ivelin]

Reverts #314

[commit-lint]

Contributors

ivelin

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

• @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
• @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
• @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
• @Commit-Lint merge disable will desactivate merge dependabot PR
• @Commit-Lint review will approve dependabot PR
• @Commit-Lint stop review will stop approve dependabot PR

[pep8speaks]

Hello @ivelin! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file src/ambianic/pipeline/ai/fall_detect.py:

Line 70:80: E501 line too long (102 > 79 characters)
Line 73:77: W291 trailing whitespace
Line 77:75: W291 trailing whitespace
Line 79:63: W291 trailing whitespace
Line 116:27: E128 continuation line under-indented for visual indent
Line 117:27: E128 continuation line under-indented for visual indent
Line 118:27: E124 closing bracket does not match visual indentation
Line 161:80: E501 line too long (96 > 79 characters)
Line 168:52: W291 trailing whitespace
Line 170:80: E501 line too long (89 > 79 characters)
Line 171:9: E265 block comment should start with '# '
Line 172:80: E501 line too long (83 > 79 characters)
Line 174:11: E111 indentation is not a multiple of four
Line 175:11: E111 indentation is not a multiple of four
Line 176:11: E114 indentation is not a multiple of four (comment)
Line 177:11: E111 indentation is not a multiple of four
Line 178:11: E111 indentation is not a multiple of four
Line 178:80: E501 line too long (85 > 79 characters)
Line 184:1: W293 blank line contains whitespace
Line 186:80: E501 line too long (96 > 79 characters)
Line 189:80: E501 line too long (82 > 79 characters)
Line 192:80: E501 line too long (121 > 79 characters)
Line 196:17: E271 multiple spaces after keyword
Line 196:45: W291 trailing whitespace
Line 197:13: E115 expected an indented block (comment)
Line 203:80: E501 line too long (124 > 79 characters)
Line 206:13: E124 closing bracket does not match visual indentation
Line 214:80: E501 line too long (92 > 79 characters)
Line 217:80: E501 line too long (125 > 79 characters)
Line 218:80: E501 line too long (98 > 79 characters)
Line 222:1: W293 blank line contains whitespace
Line 235:33: E128 continuation line under-indented for visual indent
Line 235:80: E501 line too long (85 > 79 characters)
Line 236:33: E128 continuation line under-indented for visual indent
Line 236:80: E501 line too long (90 > 79 characters)
Line 244:80: E501 line too long (134 > 79 characters)
Line 247:17: E128 continuation line under-indented for visual indent
Line 248:17: E128 continuation line under-indented for visual indent
Line 249:17: E128 continuation line under-indented for visual indent
Line 250:17: E128 continuation line under-indented for visual indent
Line 251:17: E128 continuation line under-indented for visual indent
Line 252:17: E124 closing bracket does not match visual indentation
Line 268:80: E501 line too long (93 > 79 characters)
Line 273:80: E501 line too long (95 > 79 characters)
Line 291:1: W293 blank line contains whitespace
Line 298:80: E501 line too long (114 > 79 characters)
Line 299:1: W293 blank line contains whitespace
Line 301:80: E501 line too long (116 > 79 characters)
Line 302:1: W293 blank line contains whitespace
Line 310:80: E501 line too long (108 > 79 characters)
Line 311:80: E501 line too long (111 > 79 characters)
Line 311:112: W291 trailing whitespace
Line 315:80: E501 line too long (80 > 79 characters)
Line 320:80: E501 line too long (82 > 79 characters)
Line 324:80: E501 line too long (101 > 79 characters)
Line 325:80: E501 line too long (101 > 79 characters)
Line 327:80: E501 line too long (92 > 79 characters)
Line 328:80: E501 line too long (92 > 79 characters)
Line 330:80: E501 line too long (87 > 79 characters)
Line 337:80: E501 line too long (88 > 79 characters)
Line 338:80: E501 line too long (88 > 79 characters)
Line 341:80: E501 line too long (90 > 79 characters)
Line 342:80: E501 line too long (89 > 79 characters)
Line 358:80: E501 line too long (87 > 79 characters)
Line 359:80: E501 line too long (102 > 79 characters)
Line 360:80: E501 line too long (112 > 79 characters)
Line 365:80: E501 line too long (87 > 79 characters)
Line 369:80: E501 line too long (132 > 79 characters)
Line 376:80: E501 line too long (105 > 79 characters)
Line 379:80: E501 line too long (80 > 79 characters)
Line 385:80: E501 line too long (101 > 79 characters)
Line 386:80: E501 line too long (119 > 79 characters)
Line 387:80: E501 line too long (117 > 79 characters)
Line 388:80: E501 line too long (139 > 79 characters)
Line 390:80: E501 line too long (83 > 79 characters)
Line 392:80: E501 line too long (106 > 79 characters)
Line 393:80: E501 line too long (91 > 79 characters)
Line 395:80: E501 line too long (135 > 79 characters)
Line 396:80: E501 line too long (135 > 79 characters)
Line 399:80: E501 line too long (86 > 79 characters)
Line 400:80: E501 line too long (88 > 79 characters)
Line 402:80: E501 line too long (93 > 79 characters)
Line 406:80: E501 line too long (182 > 79 characters)
Line 409:80: E501 line too long (140 > 79 characters)
Line 414:46: W291 trailing whitespace

• In the file src/ambianic/pipeline/ai/image_boundingBox_detection.py:

Line 61:80: E501 line too long (95 > 79 characters)
Line 145:33: E128 continuation line under-indented for visual indent
Line 146:33: E128 continuation line under-indented for visual indent
Line 147:33: E128 continuation line under-indented for visual indent
Line 149:33: E128 continuation line under-indented for visual indent
Line 150:33: E128 continuation line under-indented for visual indent

• In the file src/ambianic/pipeline/ai/pose_engine.py:

Line 70:49: E127 continuation line over-indented for visual indent
Line 72:80: E501 line too long (99 > 79 characters)
Line 78:80: E501 line too long (84 > 79 characters)
Line 79:80: E501 line too long (84 > 79 characters)
Line 80:80: E501 line too long (81 > 79 characters)
Line 84:80: E501 line too long (81 > 79 characters)
Line 95:45: E231 missing whitespace after ','
Line 96:80: E501 line too long (89 > 79 characters)
Line 97:80: E501 line too long (89 > 79 characters)
Line 98:80: E501 line too long (95 > 79 characters)
Line 99:80: E501 line too long (105 > 79 characters)
Line 103:80: E501 line too long (108 > 79 characters)
Line 108:1: W293 blank line contains whitespace
Line 132:80: E501 line too long (82 > 79 characters)
Line 135:80: E501 line too long (90 > 79 characters)
Line 137:80: E501 line too long (92 > 79 characters)
Line 138:80: E501 line too long (98 > 79 characters)
Line 139:1: W293 blank line contains whitespace
Line 146:80: E501 line too long (98 > 79 characters)
Line 149:80: E501 line too long (106 > 79 characters)
Line 150:80: E501 line too long (106 > 79 characters)
Line 154:1: W293 blank line contains whitespace
Line 156:1: W293 blank line contains whitespace
Line 166:1: W293 blank line contains whitespace
Line 169:80: E501 line too long (80 > 79 characters)
Line 170:21: E265 block comment should start with '# '
Line 172:34: E231 missing whitespace after ','
Line 174:66: W291 trailing whitespace
Line 177:80: E501 line too long (91 > 79 characters)
Line 181:80: E501 line too long (84 > 79 characters)
Line 184:80: E501 line too long (143 > 79 characters)

• In the file src/ambianic/pipeline/store.py:

Line 96:25: E128 continuation line under-indented for visual indent
Line 97:25: E128 continuation line under-indented for visual indent
Line 98:25: E128 continuation line under-indented for visual indent

• In the file tests/pipeline/ai/test_fall_detect.py:

Line 70:80: E501 line too long (93 > 79 characters)
Line 74:80: E501 line too long (85 > 79 characters)
Line 113:1: W293 blank line contains whitespace
Line 115:80: E501 line too long (161 > 79 characters)
Line 139:80: E501 line too long (90 > 79 characters)
Line 140:80: E501 line too long (114 > 79 characters)
Line 147:80: E501 line too long (149 > 79 characters)
Line 158:1: W293 blank line contains whitespace
Line 175:66: W291 trailing whitespace
Line 181:80: E501 line too long (93 > 79 characters)
Line 192:1: W293 blank line contains whitespace
Line 210:66: W291 trailing whitespace
Line 217:80: E501 line too long (101 > 79 characters)
Line 263:1: W293 blank line contains whitespace
Line 281:80: E501 line too long (118 > 79 characters)
Line 310:80: E501 line too long (92 > 79 characters)
Line 402:80: E501 line too long (85 > 79 characters)
Line 404:80: E501 line too long (89 > 79 characters)
Line 465:66: W291 trailing whitespace
Line 494:17: E201 whitespace after '{'
Line 494:49: E231 missing whitespace after ','
Line 494:80: E231 missing whitespace after ','
Line 494:80: E501 line too long (83 > 79 characters)
Line 505:17: E201 whitespace after '{'
Line 505:49: E231 missing whitespace after ','
Line 517:17: E201 whitespace after '{'
Line 517:49: E231 missing whitespace after ','
Line 517:80: E231 missing whitespace after ','
Line 517:80: E501 line too long (152 > 79 characters)
Line 517:117: E231 missing whitespace after ','
Line 517:149: E231 missing whitespace after ','
Line 546:80: E501 line too long (91 > 79 characters)
Line 625:80: E501 line too long (80 > 79 characters)

• In the file tests/pipeline/ai/test_fall_detect_more.py:

Line 14:25: W291 trailing whitespace
Line 31:80: E501 line too long (91 > 79 characters)
Line 59:80: E501 line too long (85 > 79 characters)

• In the file tests/pipeline/test_store.py:

Line 158:80: E501 line too long (81 > 79 characters)

[codecov]

Codecov Report

Merging #329 (025388a) into master (8768c17) will increase coverage by 0.03%.
The diff coverage is 97.33%.

@@            Coverage Diff             @@
##           master     #329      +/-   ##
==========================================
+ Coverage   94.50%   94.53%   +0.03%     
==========================================
  Files          23       23              
  Lines        2220     2197      -23     
==========================================
- Hits         2098     2077      -21     
+ Misses        122      120       -2     

Impacted Files	Coverage Δ
src/ambianic/pipeline/ai/object_detect.py	100.00% <ø> (ø)
src/ambianic/pipeline/ai/fall_detect.py	97.15% <95.45%> (-0.12%)	⬇️
src/ambianic/pipeline/ai/face_detect.py	100.00% <100.00%> (ø)
...mbianic/pipeline/ai/image_boundingBox_detection.py	100.00% <100.00%> (ø)
src/ambianic/pipeline/ai/pose_engine.py	97.93% <100.00%> (ø)
src/ambianic/pipeline/store.py	100.00% <100.00%> (ø)
src/ambianic/pipeline/interpreter.py	95.57% <0.00%> (+0.73%)	⬆️

[github-actions]

🎉 This PR is included in version 1.14.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀