fix: fall detection debug info #309

ivelin · 2021-02-10T04:31:17Z

No description provided.

commit-lint · 2021-02-10T04:31:21Z

Bug Fixes

fall detection debug info (d497374)
dall detection debug logging (f06f218)
test coverage and linting (0ff1007)
merge with upstream master (4ec3a60)
codefactor alerts (d12c999)

Chore

release: 1.10.4 [skip ci] (caee112)
fix linter warnings (04413d2)
release: 1.10.5 [skip ci] (810c5a8)
release: 1.11.0 [skip ci] (d70c8f5)

Build System

lgtm config (48edeb6)

Tests

more coverage (2cedbcd)

Contributors

ivelin, semantic-release-bot

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

@Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
@Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
@Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
@Commit-Lint merge disable will desactivate merge dependabot PR
@Commit-Lint review will approve dependabot PR
@Commit-Lint stop review will stop approve dependabot PR

pep8speaks · 2021-02-10T04:31:24Z

Hello @ivelin! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file src/ambianic/pipeline/ai/fall_detect.py:

Line 73:77: W291 trailing whitespace
Line 77:75: W291 trailing whitespace
Line 79:63: W291 trailing whitespace
Line 172:80: E501 line too long (83 > 79 characters)
Line 177:11: E111 indentation is not a multiple of four
Line 178:11: E111 indentation is not a multiple of four
Line 178:80: E501 line too long (85 > 79 characters)
Line 203:80: E501 line too long (124 > 79 characters)
Line 206:13: E124 closing bracket does not match visual indentation
Line 365:80: E501 line too long (87 > 79 characters)
Line 369:80: E501 line too long (132 > 79 characters)
Line 379:80: E501 line too long (80 > 79 characters)

In the file src/ambianic/pipeline/ai/pose_engine.py:

Line 169:80: E501 line too long (80 > 79 characters)
Line 170:21: E265 block comment should start with '# '
Line 172:34: E231 missing whitespace after ','
Line 181:80: E501 line too long (84 > 79 characters)
Line 184:80: E501 line too long (143 > 79 characters)

In the file tests/pipeline/ai/test_fall_detect_more.py:

Line 14:25: W291 trailing whitespace
Line 59:80: E501 line too long (85 > 79 characters)

Comment last updated at 2021-02-13 05:41:57 UTC

codecov · 2021-02-10T04:36:35Z

Codecov Report

Merging #309 (7dfa188) into master (636e417) will increase coverage by 0.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #309      +/-   ##
==========================================
+ Coverage   94.30%   94.44%   +0.13%     
==========================================
  Files          23       23              
  Lines        2179     2197      +18     
==========================================
+ Hits         2055     2075      +20     
+ Misses        124      122       -2

Impacted Files	Coverage Δ
src/ambianic/logger.py	`100.00% <ø> (ø)`
src/ambianic/pipeline/ai/fall_detect.py	`97.15% <100.00%> (+1.48%)`	⬆️
src/ambianic/pipeline/ai/pose_engine.py	`97.93% <100.00%> (+0.34%)`	⬆️
src/ambianic/pipeline/avsource/picam.py	`93.15% <100.00%> (+0.29%)`	⬆️
src/ambianic/server.py	`99.06% <100.00%> (-0.01%)`	⬇️
src/ambianic/pipeline/interpreter.py	`94.83% <0.00%> (-0.74%)`	⬇️
src/ambianic/pipeline/timeline.py	`65.33% <0.00%> (+1.33%)`	⬆️

lgtm-com · 2021-02-10T04:38:21Z

This pull request fixes 1 alert when merging d497374 into 89037de - view on LGTM.com

fixed alerts:

1 for Unused import

## [1.10.4](v1.10.3...v1.10.4) (2021-02-10) ### Bug Fixes * fall detection confidence_threshold propagation ([08609a7](08609a7)), closes [ambianic#307](https://github.com/ivelin/ambianic-edge/issues/307) * fall detection debug info ([d497374](d497374))

CLAassistant · 2021-02-10T05:13:33Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ ivelin
❌ semantic-release-bot
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

lgtm-com · 2021-02-10T05:21:47Z

This pull request fixes 1 alert when merging caee112 into 89037de - view on LGTM.com

fixed alerts:

1 for Unused import

lgtm-com · 2021-02-10T06:01:54Z

This pull request fixes 1 alert when merging c5b9b9a into 89037de - view on LGTM.com

fixed alerts:

1 for Unused import

lgtm-com · 2021-02-10T06:13:23Z

This pull request fixes 2 alerts when merging 04413d2 into 89037de - view on LGTM.com

fixed alerts:

2 for Unused import

## [1.10.5](v1.10.4...v1.10.5) (2021-02-10) ### Bug Fixes * dall detection debug logging ([f06f218](f06f218))

lgtm-com · 2021-02-10T06:56:43Z

This pull request fixes 2 alerts when merging 810c5a8 into 89037de - view on LGTM.com

fixed alerts:

2 for Unused import

lgtm-com · 2021-02-13T01:23:06Z

LGTM pull request analysis was skipped for 810c5a8 by ivelin. Analysis of future commits will happen as normal.

lgtm-com · 2021-02-13T04:45:19Z

This pull request introduces 1 alert and fixes 5 when merging d12c999 into 636e417 - view on LGTM.com

new alerts:

1 for Unused local variable

fixed alerts:

5 for Unused import

# [1.11.0](v1.10.5...v1.11.0) (2021-02-13) ### Bug Fixes * codefactor alerts ([d12c999](d12c999)) * merge with upstream master ([4ec3a60](4ec3a60)) * test coverage and linting ([0ff1007](0ff1007)) ### Features * introduced single sourcing for edge version ([27541d5](27541d5)), closes [ambianic#308](https://github.com/ivelin/ambianic-edge/issues/308) * Introduced single sourcing for edge version ([c2d122b](c2d122b))

lgtm-com · 2021-02-13T05:29:18Z

This pull request introduces 1 alert and fixes 5 when merging bc0d2f6 into 636e417 - view on LGTM.com

new alerts:

1 for Unused local variable

fixed alerts:

5 for Unused import

lgtm-com · 2021-02-13T05:49:09Z

This pull request introduces 1 alert and fixes 5 when merging 2cedbcd into 636e417 - view on LGTM.com

new alerts:

1 for Unused local variable

fixed alerts:

5 for Unused import

## [1.14.1](v1.14.0...v1.14.1) (2021-02-13) ### Bug Fixes * codefactor alerts ([d12c999](d12c999)) * dall detection debug logging ([f06f218](f06f218)) * fall detection debug info ([d497374](d497374)) * improve fall detection debug info ([7762752](7762752)), closes [#309](#309) * merge with upstream master ([4ec3a60](4ec3a60)) * test coverage and linting ([0ff1007](0ff1007))

github-actions · 2021-02-13T06:55:43Z

🎉 This PR is included in version 1.14.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

fix: fall detection debug info

d497374

pull-request-size bot added the size/M label Feb 10, 2021

ivelin added 2 commits February 10, 2021 05:52

fix: dall detection debug logging

f06f218

Merge branch 'master' of https://github.com/ivelin/ambianic-edge

c5b9b9a

chore: fix linter warnings

04413d2

pull-request-size bot added size/L and removed size/M labels Feb 10, 2021

chore(release): 1.10.5 [skip ci]

810c5a8

## [1.10.5](v1.10.4...v1.10.5) (2021-02-10) ### Bug Fixes * dall detection debug logging ([f06f218](f06f218))

ivelin marked this pull request as draft February 10, 2021 19:35

ivelin added 3 commits February 13, 2021 04:07

fix: test coverage and linting

0ff1007

fix: merge with upstream master

4ec3a60

fix: codefactor alerts

d12c999

semantic-release-bot and others added 3 commits February 13, 2021 05:20

build: lgtm config

48edeb6

Merge branch 'master' of https://github.com/ivelin/ambianic-edge

bc0d2f6

test: more coverage

2cedbcd

ivelin marked this pull request as ready for review February 13, 2021 06:09

ivelin merged commit 7762752 into ambianic:master Feb 13, 2021

github-actions bot added the released label Feb 13, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: fall detection debug info #309

fix: fall detection debug info #309

ivelin commented Feb 10, 2021

commit-lint bot commented Feb 10, 2021 •

edited

Loading

pep8speaks commented Feb 10, 2021 •

edited

Loading

codecov bot commented Feb 10, 2021 •

edited

Loading

lgtm-com bot commented Feb 10, 2021

CLAassistant commented Feb 10, 2021

lgtm-com bot commented Feb 10, 2021

lgtm-com bot commented Feb 10, 2021

lgtm-com bot commented Feb 10, 2021

lgtm-com bot commented Feb 10, 2021

lgtm-com bot commented Feb 13, 2021

lgtm-com bot commented Feb 13, 2021

lgtm-com bot commented Feb 13, 2021

lgtm-com bot commented Feb 13, 2021

github-actions bot commented Feb 13, 2021

fix: fall detection debug info #309

fix: fall detection debug info #309

Conversation

ivelin commented Feb 10, 2021

commit-lint bot commented Feb 10, 2021 • edited Loading

Bug Fixes

Chore

Build System

Tests

Contributors

pep8speaks commented Feb 10, 2021 • edited Loading

Comment last updated at 2021-02-13 05:41:57 UTC

codecov bot commented Feb 10, 2021 • edited Loading

Codecov Report

lgtm-com bot commented Feb 10, 2021

CLAassistant commented Feb 10, 2021

lgtm-com bot commented Feb 10, 2021

lgtm-com bot commented Feb 10, 2021

lgtm-com bot commented Feb 10, 2021

lgtm-com bot commented Feb 10, 2021

lgtm-com bot commented Feb 13, 2021

lgtm-com bot commented Feb 13, 2021

lgtm-com bot commented Feb 13, 2021

lgtm-com bot commented Feb 13, 2021

github-actions bot commented Feb 13, 2021

commit-lint bot commented Feb 10, 2021 •

edited

Loading

pep8speaks commented Feb 10, 2021 •

edited

Loading

codecov bot commented Feb 10, 2021 •

edited

Loading