Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Pose Engine returns pose coordinates as original image pixel coordinates #254

Closed
ivelin opened this issue Dec 12, 2020 · 2 comments · Fixed by #314
Closed

[BUG] Pose Engine returns pose coordinates as original image pixel coordinates #254

ivelin opened this issue Dec 12, 2020 · 2 comments · Fixed by #314
Assignees
@bhavikapanara
Labels
bug Something isn't working released

Comments

@ivelin
Copy link
Collaborator

ivelin commented Dec 12, 2020

Describe the bug
Currently pose engine returns pose keypoint coordinates as pixel coordinates in the original input image.
This is not ideal, because we send over the wire to the UI timeline just a thumbnail image, which is a scaled down lighter version of the original image.

To be consistent with other detection models, pose engine should return key points as relative values from 0 to 1 and let the visualization component calculate pixel coordinates right before they are shown to the user.

For privacy concerns, we may not even show the original image or thumbnail to some users, but instead only the stick figure with the pose keypoints.

Additional context
See here.
@ivelin ivelin added the bug Something isn't working label Dec 12, 2020
bhavikapanara added a commit to bhavikapanara/ambianic-edge that referenced this issue Feb 4, 2021
@bhavikapanara
fix issue ambianic#254
45aa33b
@ivelin ivelin linked a pull request Feb 5, 2021 that will close this issue
fix: pose engine coordinates in inference output; closes #254 #296
Closed
@ivelin ivelin closed this as completed in 8768c17 Feb 17, 2021
@ivelin ivelin linked a pull request Feb 17, 2021 that will close this issue
fix: separate inference output formatting for each detection model; closes #254 #314
Merged
github-actions bot pushed a commit that referenced this issue Feb 17, 2021
@semantic-release-bot
chore(release): 1.14.2 [skip ci]
df25293 
## [1.14.2](v1.14.1...v1.14.2) (2021-02-17)

### Bug Fixes

* separate inference output formatting for each detection model; closes [#254](#254) ([8768c17](8768c17)), closes [#314](#314)
@github-actions
Copy link

🎉 This issue has been resolved in version 1.14.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

ivelin pushed a commit that referenced this issue Feb 18, 2021
Revert "fix: separate inference output formatting for each detection …
606b359 
…model; closes #254"
ivelin pushed a commit that referenced this issue Feb 18, 2021
fix: revert #314; see #330 for details; separate inference output for…
ee79c40 
…matting for each detection model; closes #254"

Merge pull request #329 from ambianic/revert-314-feat/dev-inference-output
github-actions bot pushed a commit that referenced this issue Feb 18, 2021
@semantic-release-bot
chore(release): 1.14.3 [skip ci]
08a9081 
## [1.14.3](v1.14.2...v1.14.3) (2021-02-18)

### Bug Fixes

* revert [#314](#314); see [#330](#330) for details; separate inference output formatting for each detection model; closes [#254](#254)" ([ee79c40](ee79c40)), closes [#329](#329)
@github-actions
Copy link

🎉 This issue has been resolved in version 1.14.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@bhavikapanara bhavikapanara mentioned this issue Feb 19, 2021
Merged
ivelin pushed a commit that referenced this issue Feb 24, 2021
fix: separate inference output formatting for each detection model; […
b83e4f8 
…issues #330, #254]

Merge pull request #332 from bhavikapanara/feat/dev-inference-output-updated
github-actions bot pushed a commit that referenced this issue Feb 25, 2021
@semantic-release-bot
chore(release): 1.14.4 [skip ci]
6364c26 
## [1.14.4](v1.14.3...v1.14.4) (2021-02-25)

### Bug Fixes

* separate inference output formatting for each detection model; [issues [#330](#330), [#254](#254)] ([b83e4f8](b83e4f8)), closes [#332](#332)
github-actions bot pushed a commit to ivelin/ambianic-edge that referenced this issue May 17, 2021
@semantic-release-bot
chore(release): 1.11.1 [skip ci]
96b1d2f 
## [1.11.1](v1.11.0...v1.11.1) (2021-05-17)

### Bug Fixes

* build and publish python API docs ([2091c54](2091c54)), closes [ambianic#342](https://github.com/ivelin/ambianic-edge/issues/342)
* improve fall detection debug info ([7762752](7762752)), closes [ambianic#309](https://github.com/ivelin/ambianic-edge/issues/309)
* json serialization redundancy issue in store.py; closes [ambianic#337](https://github.com/ivelin/ambianic-edge/issues/337); closes [ambianic#300](https://github.com/ivelin/ambianic-edge/issues/300) ([bb8d20a](bb8d20a)), closes [ambianic#339](https://github.com/ivelin/ambianic-edge/issues/339)
* revert [ambianic#314](https://github.com/ivelin/ambianic-edge/issues/314); see [ambianic#330](https://github.com/ivelin/ambianic-edge/issues/330) for details; separate inference output formatting for each detection model; closes [ambianic#254](https://github.com/ivelin/ambianic-edge/issues/254)" ([ee79c40](ee79c40)), closes [ambianic#329](https://github.com/ivelin/ambianic-edge/issues/329)
* separate inference output formatting for each detection model; [issues [ambianic#330](https://github.com/ivelin/ambianic-edge/issues/330), [ambianic#254](https://github.com/ivelin/ambianic-edge/issues/254)] ([b83e4f8](b83e4f8)), closes [ambianic#332](https://github.com/ivelin/ambianic-edge/issues/332)
* separate inference output formatting for each detection model; closes [ambianic#254](https://github.com/ivelin/ambianic-edge/issues/254) ([8768c17](8768c17)), closes [ambianic#314](https://github.com/ivelin/ambianic-edge/issues/314)
* temporary solution to manage yaml.dump() encoding issue; closes [ambianic#330](https://github.com/ivelin/ambianic-edge/issues/330) ([db4b00a](db4b00a)), closes [ambianic#333](https://github.com/ivelin/ambianic-edge/issues/333)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bhavikapanara bhavikapanara

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
2 participants
@ivelin @bhavikapanara