Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] Stage to Main #3072

Merged
merged 9 commits into from
Oct 23, 2024
Merged

[Release] Stage to Main #3072

merged 9 commits into from
Oct 23, 2024

Conversation

npeltier and others added 9 commits October 22, 2024 08:03
* initial commit

* slots, styles and basic layout

* more changes

* Update merch-card.ccd-suggested.test.html

* Update merch-twp-d2p.test.html

* unit tests, strip slot and more

* fixed review comments

* review comments fixed

* RTL background image support

* Initial @adobecom/mas-js version.

* a

* Update merch-card.ccd-suggested.test.html

* a

* dark mode, unit tests and rtl

* simplified styles

* updated deps

* Update variant-layout.js

* dark theme ut

* Update merch-card.ccd-suggested.test.html.js

* Update variant-layout.js

* card mapping

* MWPW-158200: Merch card Dark mode

* updated deps

* MWPW-159257 refactor mas enablement

- move of wcms-commerce -> mas-commerce-service
- move of some public functions to mas-commerce-service,
- remove mas.js code for initialization, everything needs to go through the component,
- split of settings code with locale settings, make milo locale settings an explicit function,
- unit tests,
- updates of docs, especially  mas.js.html with that component

* MWPW-159257 fix unit test + register co

* review comments fixed

* MWPW-159257 some feedbacks, more coverage

* draft

* bump pkg version

* MWPW-160085: WIP

* wip

* fix cta mapping for suggested card

* ccd-suggested fixes

* dark theme update

* remove css var

* fix size attribute in hydrate

* MWPW-159257 remove init & reset concept

- also removed typescript stuff,
- refactor mixin to simple aggregated MasElement,
- refactor how things are initialised"

* update docs

* merge changes, add more docs

* update docs

* MWPW-159257 remove init & reset concept

- also removed typescript stuff,
- refactor mixin to simple aggregated MasElement,
- refactor how things are initialised,
- make merch block working with this

* update docs

* merge changes, add more docs

* update docs

* fix docu

* merge

* re-enable notification test

* ost

* add doc

* various fixes

* MWPW-159257 move to relative path

* MWPW-159257 various fixes

* rename promise -> readyPromise

not documenting it as i'm not sure it's needed by consumers

* MWPW-159257 enhance coverage

* MWPW-159257 yet more coverage

* MWPW-159257 final?

* MWPW-159257 non reported cov issues

* prob. some issue in cov reporting as its used several times

* MWPW-159257 review fixes

* yet some over c8 ignore

* MWPW-159257 removing it.only & built docs

* MWPW-159257 unwrap single condition block

* MWPW-159257: [M@S] Support override env/landscape

Milo only consumes WCS prod.
However with this PR, on local and stage environments, `allow-override`
parameter will be added to `mas-commerce-service` allowing to override
the commerce env/landscape via query parameters.

* PR feedback

* reduce codecov requirement

---------

Co-authored-by: Axel Cureno Basurto <axel@adobe.com>
Co-authored-by: Ilyas Türkben <ilyas@adobe.com>
Co-authored-by: Mariia Lukianets <mariia.lukianets@gmail.com>
* How-to Video Support AdobeTV and mp4

* Adding observer

* Test files

* Removing chaining

* How to updates

* Returning an object

* Update libs/blocks/how-to/how-to.css

Co-authored-by: Ryan Parrish <churchofslidin@gmail.com>

* Rolling back errors

* Removing parent

---------

Co-authored-by: Ryan Parrish <churchofslidin@gmail.com>
* MWPW-142878 add events for milo post lcp & milo delayed

* MWPW-142878 fixes after review & fix unit tests

* MWPW-142878 remove events and pass callback to google login

* MWPW-142878 fix tests

* MWPW-142878 make call async

* MWPW-142878 add small change to restart code checks

* MWPW-142878 remove change

* MWPW-142878 make code a little cleaner and syncronized

* MWPW-142878 make line shorter

* MWPW-142878 make unit test a little better
…lders() (#3007)

* added no placeholders case for parsePlaceholders()

* added fix to a case where no placeholder was found

* added test fix

---------

Co-authored-by: Denys Fedotov <dfedotov@Denyss-MacBook-Pro.local>
Graybox no-click fix

*graybox no-click now properly restricts clicks and selection

Resolves: [MWPW-157690](https://jira.corp.adobe.com/browse/MWPW-157690)
* Saving WIP

* Temporarily adding mock endpoint to test e2e

* Making panel for partial load settings toggle

* Removing accidentally commited code

* Fixing linting issue

* Updating config to fix unit tests

* Fixing linting + more test stuff

* Next attempt at fixing linting + tests
…rvis fix for standalone GNAV (#3020)

* Add config for full width Standalone GNAV

* lint fix

* UT coverage

* fix reveiw comment

* Make GNAV border bottom configurable for standalone GNAV

* UT added

* relative url AED disable for custom links

* Fix review comment

* relative url AED disable for custom links

* fix active link href

* UT

* Added jarvis fix in this PR
* Clickable app and playstore links

* use the correct order

* Add safeguards
* Possible working modal suppression.

* Added conditional parameters and unit test.
@milo-pr-merge
Copy link
Contributor Author

milo-pr-merge bot commented Oct 22, 2024

Testing can start @adobecom/miq-sot @adobecom/bacom-sot @adobecom/homepage-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot

Copy link
Contributor

aem-code-sync bot commented Oct 22, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Oct 22, 2024

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

eslint

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/c30fa5bb9b5a96ae279ee2136244d0f374b6f83f/libs/deps/mas/plans-modal.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/c30fa5bb9b5a96ae279ee2136244d0f374b6f83f/libs/features/mas/commerce/src/checkout-link.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/c30fa5bb9b5a96ae279ee2136244d0f374b6f83f/libs/features/mas/commerce/src/checkout.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/c30fa5bb9b5a96ae279ee2136244d0f374b6f83f/libs/features/mas/commerce/src/constants.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/c30fa5bb9b5a96ae279ee2136244d0f374b6f83f/libs/features/mas/commerce/src/ims.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/c30fa5bb9b5a96ae279ee2136244d0f374b6f83f/libs/features/mas/commerce/src/index.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/c30fa5bb9b5a96ae279ee2136244d0f374b6f83f/libs/features/mas/commerce/src/inline-price.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/c30fa5bb9b5a96ae279ee2136244d0f374b6f83f/libs/features/mas/commerce/src/lana.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/c30fa5bb9b5a96ae279ee2136244d0f374b6f83f/libs/features/mas/commerce/src/literals.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/c30fa5bb9b5a96ae279ee2136244d0f374b6f83f/libs/features/mas/commerce/src/log.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/c30fa5bb9b5a96ae279ee2136244d0f374b6f83f/libs/features/mas/commerce/src/mas-commerce-service.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/c30fa5bb9b5a96ae279ee2136244d0f374b6f83f/libs/features/mas/commerce/src/mas-element.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/c30fa5bb9b5a96ae279ee2136244d0f374b6f83f/libs/features/mas/commerce/src/price.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/c30fa5bb9b5a96ae279ee2136244d0f374b6f83f/libs/features/mas/commerce/src/settings.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/c30fa5bb9b5a96ae279ee2136244d0f374b6f83f/libs/features/mas/commerce/src/utilities.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/c30fa5bb9b5a96ae279ee2136244d0f374b6f83f/libs/features/mas/commerce/src/wcs.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/c30fa5bb9b5a96ae279ee2136244d0f374b6f83f/libs/features/mas/commerce/test/checkout.test.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/c30fa5bb9b5a96ae279ee2136244d0f374b6f83f/libs/features/mas/commerce/test/lana.test.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/c30fa5bb9b5a96ae279ee2136244d0f374b6f83f/libs/features/mas/commerce/test/literals.test.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/c30fa5bb9b5a96ae279ee2136244d0f374b6f83f/libs/features/mas/commerce/test/mas-commerce-service.test.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/c30fa5bb9b5a96ae279ee2136244d0f374b6f83f/libs/features/mas/commerce/test/price.test.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/c30fa5bb9b5a96ae279ee2136244d0f374b6f83f/libs/features/mas/commerce/test/settings.test.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/c30fa5bb9b5a96ae279ee2136244d0f374b6f83f/libs/features/mas/commerce/test/utilities.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/c30fa5bb9b5a96ae279ee2136244d0f374b6f83f/libs/features/mas/commerce/test/utilities.test.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/c30fa5bb9b5a96ae279ee2136244d0f374b6f83f/libs/features/mas/commerce/test/wcs.test.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/c30fa5bb9b5a96ae279ee2136244d0f374b6f83f/libs/features/mas/mas/dist/mas.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/c30fa5bb9b5a96ae279ee2136244d0f374b6f83f/libs/features/mas/mas/src/mas.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/c30fa5bb9b5a96ae279ee2136244d0f374b6f83f/libs/features/mas/web-components/src/aem-fragment.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/c30fa5bb9b5a96ae279ee2136244d0f374b6f83f/libs/features/mas/web-components/src/constants.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/c30fa5bb9b5a96ae279ee2136244d0f374b6f83f/libs/features/mas/web-components/src/global.css.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/c30fa5bb9b5a96ae279ee2136244d0f374b6f83f/libs/features/mas/web-components/src/hydrate.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/c30fa5bb9b5a96ae279ee2136244d0f374b6f83f/libs/features/mas/web-components/src/merch-card.css.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/c30fa5bb9b5a96ae279ee2136244d0f374b6f83f/libs/features/mas/web-components/src/merch-card.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/c30fa5bb9b5a96ae279ee2136244d0f374b6f83f/libs/features/mas/web-components/src/merch-offer.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/c30fa5bb9b5a96ae279ee2136244d0f374b6f83f/libs/features/mas/web-components/src/merch-search.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/c30fa5bb9b5a96ae279ee2136244d0f374b6f83f/libs/features/mas/web-components/src/variants/catalog.css.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/c30fa5bb9b5a96ae279ee2136244d0f374b6f83f/libs/features/mas/web-components/src/variants/ccd-slice.css.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/c30fa5bb9b5a96ae279ee2136244d0f374b6f83f/libs/features/mas/web-components/src/variants/ccd-slice.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/c30fa5bb9b5a96ae279ee2136244d0f374b6f83f/libs/features/mas/web-components/src/variants/ccd-suggested.css.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/c30fa5bb9b5a96ae279ee2136244d0f374b6f83f/libs/features/mas/web-components/src/variants/ccd-suggested.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/c30fa5bb9b5a96ae279ee2136244d0f374b6f83f/libs/features/mas/web-components/src/variants/variant-layout.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/c30fa5bb9b5a96ae279ee2136244d0f374b6f83f/libs/features/mas/web-components/src/variants/variants.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/c30fa5bb9b5a96ae279ee2136244d0f374b6f83f/libs/features/mas/web-components/test/aem-fragment.test.html.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/c30fa5bb9b5a96ae279ee2136244d0f374b6f83f/libs/features/mas/web-components/test/mas.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/c30fa5bb9b5a96ae279ee2136244d0f374b6f83f/libs/features/mas/web-components/test/merch-card-collection.test.html.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/c30fa5bb9b5a96ae279ee2136244d0f374b6f83f/libs/features/mas/web-components/test/merch-card.catalog.test.html.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/c30fa5bb9b5a96ae279ee2136244d0f374b6f83f/libs/features/mas/web-components/test/merch-card.ccd-suggested.test.html.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/c30fa5bb9b5a96ae279ee2136244d0f374b6f83f/libs/features/mas/web-components/test/merch-card.mini-compare.mobile.test.html.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/c30fa5bb9b5a96ae279ee2136244d0f374b6f83f/libs/features/mas/web-components/test/merch-card.special-offer.test.html.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/c30fa5bb9b5a96ae279ee2136244d0f374b6f83f/libs/features/mas/web-components/test/merch-card.test.html.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/c30fa5bb9b5a96ae279ee2136244d0f374b6f83f/libs/features/mas/web-components/test/merch-twp-d2p.utils.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/c30fa5bb9b5a96ae279ee2136244d0f374b6f83f/libs/features/mas/web-components/test/merch-whats-included.html.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/c30fa5bb9b5a96ae279ee2136244d0f374b6f83f/libs/features/mas/web-components/test/spectrum.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/c30fa5bb9b5a96ae279ee2136244d0f374b6f83f/libs/features/mas/web-components/test/utils.js

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 99.92537% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.43%. Comparing base (332c3a5) to head (c30fa5b).
Report is 74 commits behind head on main.

Files with missing lines Patch % Lines
libs/features/mas/commerce/src/inline-price.js 99.24% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3072      +/-   ##
==========================================
+ Coverage   96.40%   96.43%   +0.02%     
==========================================
  Files         243      245       +2     
  Lines       55415    55727     +312     
==========================================
+ Hits        53425    53740     +315     
+ Misses       1990     1987       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@milo-pr-merge milo-pr-merge bot merged commit b6e139d into main Oct 23, 2024
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.