-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Release] Stage to Main #3072
[Release] Stage to Main #3072
Conversation
* initial commit * slots, styles and basic layout * more changes * Update merch-card.ccd-suggested.test.html * Update merch-twp-d2p.test.html * unit tests, strip slot and more * fixed review comments * review comments fixed * RTL background image support * Initial @adobecom/mas-js version. * a * Update merch-card.ccd-suggested.test.html * a * dark mode, unit tests and rtl * simplified styles * updated deps * Update variant-layout.js * dark theme ut * Update merch-card.ccd-suggested.test.html.js * Update variant-layout.js * card mapping * MWPW-158200: Merch card Dark mode * updated deps * MWPW-159257 refactor mas enablement - move of wcms-commerce -> mas-commerce-service - move of some public functions to mas-commerce-service, - remove mas.js code for initialization, everything needs to go through the component, - split of settings code with locale settings, make milo locale settings an explicit function, - unit tests, - updates of docs, especially mas.js.html with that component * MWPW-159257 fix unit test + register co * review comments fixed * MWPW-159257 some feedbacks, more coverage * draft * bump pkg version * MWPW-160085: WIP * wip * fix cta mapping for suggested card * ccd-suggested fixes * dark theme update * remove css var * fix size attribute in hydrate * MWPW-159257 remove init & reset concept - also removed typescript stuff, - refactor mixin to simple aggregated MasElement, - refactor how things are initialised" * update docs * merge changes, add more docs * update docs * MWPW-159257 remove init & reset concept - also removed typescript stuff, - refactor mixin to simple aggregated MasElement, - refactor how things are initialised, - make merch block working with this * update docs * merge changes, add more docs * update docs * fix docu * merge * re-enable notification test * ost * add doc * various fixes * MWPW-159257 move to relative path * MWPW-159257 various fixes * rename promise -> readyPromise not documenting it as i'm not sure it's needed by consumers * MWPW-159257 enhance coverage * MWPW-159257 yet more coverage * MWPW-159257 final? * MWPW-159257 non reported cov issues * prob. some issue in cov reporting as its used several times * MWPW-159257 review fixes * yet some over c8 ignore * MWPW-159257 removing it.only & built docs * MWPW-159257 unwrap single condition block * MWPW-159257: [M@S] Support override env/landscape Milo only consumes WCS prod. However with this PR, on local and stage environments, `allow-override` parameter will be added to `mas-commerce-service` allowing to override the commerce env/landscape via query parameters. * PR feedback * reduce codecov requirement --------- Co-authored-by: Axel Cureno Basurto <axel@adobe.com> Co-authored-by: Ilyas Türkben <ilyas@adobe.com> Co-authored-by: Mariia Lukianets <mariia.lukianets@gmail.com>
* How-to Video Support AdobeTV and mp4 * Adding observer * Test files * Removing chaining * How to updates * Returning an object * Update libs/blocks/how-to/how-to.css Co-authored-by: Ryan Parrish <churchofslidin@gmail.com> * Rolling back errors * Removing parent --------- Co-authored-by: Ryan Parrish <churchofslidin@gmail.com>
* MWPW-142878 add events for milo post lcp & milo delayed * MWPW-142878 fixes after review & fix unit tests * MWPW-142878 remove events and pass callback to google login * MWPW-142878 fix tests * MWPW-142878 make call async * MWPW-142878 add small change to restart code checks * MWPW-142878 remove change * MWPW-142878 make code a little cleaner and syncronized * MWPW-142878 make line shorter * MWPW-142878 make unit test a little better
…lders() (#3007) * added no placeholders case for parsePlaceholders() * added fix to a case where no placeholder was found * added test fix --------- Co-authored-by: Denys Fedotov <dfedotov@Denyss-MacBook-Pro.local>
Graybox no-click fix *graybox no-click now properly restricts clicks and selection Resolves: [MWPW-157690](https://jira.corp.adobe.com/browse/MWPW-157690)
* Saving WIP * Temporarily adding mock endpoint to test e2e * Making panel for partial load settings toggle * Removing accidentally commited code * Fixing linting issue * Updating config to fix unit tests * Fixing linting + more test stuff * Next attempt at fixing linting + tests
…rvis fix for standalone GNAV (#3020) * Add config for full width Standalone GNAV * lint fix * UT coverage * fix reveiw comment * Make GNAV border bottom configurable for standalone GNAV * UT added * relative url AED disable for custom links * Fix review comment * relative url AED disable for custom links * fix active link href * UT * Added jarvis fix in this PR
* Clickable app and playstore links * use the correct order * Add safeguards
* Possible working modal suppression. * Added conditional parameters and unit test.
Testing can start @adobecom/miq-sot @adobecom/bacom-sot @adobecom/homepage-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot |
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
eslint
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3072 +/- ##
==========================================
+ Coverage 96.40% 96.43% +0.02%
==========================================
Files 243 245 +2
Lines 55415 55727 +312
==========================================
+ Hits 53425 53740 +315
+ Misses 1990 1987 -3 ☔ View full report in Codecov by Sentry. |
common base root URLs
Homepage : https://www.stage.adobe.com/
BACOM: https://business.stage.adobe.com/fr/
CC: https://www.stage.adobe.com/creativecloud.html
Blog: https://blog.stage.adobe.com/
Acrobat: https://www.stage.adobe.com/acrobat/online/sign-pdf.html
Milo: