-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-157618: How-to block video support for mp4 and adobetv #3029
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3029 +/- ##
=======================================
Coverage 96.34% 96.34%
=======================================
Files 243 243
Lines 55284 55284
=======================================
Hits 53261 53261
Misses 2023 2023 ☔ View full report in Codecov by Sentry. |
c19cb3b
to
0cf146c
Compare
0cf146c
to
91d0491
Compare
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
Let's turn this into a real PR and not a draft - we'll definitely need a fix for this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm seeing some regression issues. Can you take a look and make sure there are no impacting changes to current content.
Before: https://main--milo--adobecom.hlx.page/docs/library/blocks/howto
After: https://mwpw-157618--milo--joaquinrivero.hlx.page/docs/library/blocks/howto
Maybe you could add these to the description and also update the exiting before link to a useful comparison. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lovely, there's some nala tests failing related to videos - however once they are fixed - this looks great! 👍
Co-authored-by: Ryan Parrish <churchofslidin@gmail.com>
…-157618 * 'MWPW-157618' of github.com:joaquinrivero/milo: Update libs/blocks/how-to/how-to.css
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 👍 Marking this as high priority as this is an existing production issue that we should fix asap after the RCP.
With the label, this will get priority over other PRs and ensure it gets merged with priority by the automation.
Resolves: MWPW-157618
Test URLs:
HOW TO
Onhover play
Onviewport play
Only desktop (mobile should not load the video for perf reasons)
Split marquee video tests
CLS
BACOM tests
CC tests