Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-157618: How-to block video support for mp4 and adobetv #3029

Merged
merged 10 commits into from
Oct 22, 2024

Conversation

joaquinrivero
Copy link
Contributor

@joaquinrivero joaquinrivero commented Oct 9, 2024

  • How-to block video support for mp4 and Adobe TV

Resolves: MWPW-157618

Test URLs:

HOW TO

Onhover play

Onviewport play

Only desktop (mobile should not load the video for perf reasons)

Split marquee video tests

CLS

BACOM tests

CC tests

@joaquinrivero joaquinrivero added the needs-verification PR requires E2E testing by a reviewer label Oct 9, 2024
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.34%. Comparing base (1bdfd4a) to head (6a22349).
Report is 19 commits behind head on stage.

Additional details and impacted files
@@           Coverage Diff           @@
##            stage    #3029   +/-   ##
=======================================
  Coverage   96.34%   96.34%           
=======================================
  Files         243      243           
  Lines       55284    55284           
=======================================
  Hits        53261    53261           
  Misses       2023     2023           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joaquinrivero joaquinrivero force-pushed the MWPW-157618 branch 4 times, most recently from c19cb3b to 0cf146c Compare October 10, 2024 00:48
Copy link
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

libs/blocks/how-to/how-to.js Outdated Show resolved Hide resolved
libs/blocks/how-to/how-to.js Show resolved Hide resolved
libs/blocks/how-to/how-to.js Outdated Show resolved Hide resolved
@mokimo mokimo marked this pull request as ready for review October 10, 2024 09:32
@mokimo
Copy link
Contributor

mokimo commented Oct 10, 2024

Let's turn this into a real PR and not a draft - we'll definitely need a fix for this.

Copy link
Contributor

@ryanmparrish ryanmparrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing some regression issues. Can you take a look and make sure there are no impacting changes to current content.

Before: https://main--milo--adobecom.hlx.page/docs/library/blocks/howto
After: https://mwpw-157618--milo--joaquinrivero.hlx.page/docs/library/blocks/howto

Maybe you could add these to the description and also update the exiting before link to a useful comparison. Thanks

@Blainegunn Blainegunn removed their request for review October 15, 2024 19:01
@joaquinrivero joaquinrivero requested a review from a team as a code owner October 16, 2024 07:23
libs/utils/decorate.js Outdated Show resolved Hide resolved
Copy link
Contributor

@mokimo mokimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely, there's some nala tests failing related to videos - however once they are fixed - this looks great! 👍

joaquinrivero and others added 5 commits October 16, 2024 21:44
Co-authored-by: Ryan Parrish <churchofslidin@gmail.com>
…-157618

* 'MWPW-157618' of github.com:joaquinrivero/milo:
  Update libs/blocks/how-to/how-to.css
Copy link
Contributor

aem-code-sync bot commented Oct 16, 2024

Page Scores Audits Google
📱 / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Contributor

@mokimo mokimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍 Marking this as high priority as this is an existing production issue that we should fix asap after the RCP.
With the label, this will get priority over other PRs and ensure it gets merged with priority by the automation.

@mokimo mokimo added the high priority Why is this a high priority? Blocker? Critical? Dependency? label Oct 16, 2024
@tedAir tedAir self-requested a review October 22, 2024 07:39
@milo-pr-merge milo-pr-merge bot merged commit de2469b into adobecom:stage Oct 22, 2024
26 checks passed
@milo-pr-merge milo-pr-merge bot mentioned this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DC SOT 👌 high priority Why is this a high priority? Blocker? Critical? Dependency? needs-verification PR requires E2E testing by a reviewer Ready for Stage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants