Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-160061: Clickable App and Playstore links #3021

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

mokimo
Copy link
Contributor

@mokimo mokimo commented Oct 8, 2024

Description

Make the app store and play store links clickable again which got lost as part of #1768

Resolves: MWPW-160061

Test URLs:

@mokimo mokimo requested a review from ryanmparrish as a code owner October 8, 2024 13:27
Copy link
Contributor

aem-code-sync bot commented Oct 8, 2024

Page Scores Audits Google
📱 /drafts/sara/media?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /drafts/sara/media?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@mokimo mokimo requested a review from narcis-radu October 8, 2024 13:29
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.34%. Comparing base (1bdfd4a) to head (1dacf0b).
Report is 23 commits behind head on stage.

Additional details and impacted files
@@           Coverage Diff           @@
##            stage    #3021   +/-   ##
=======================================
  Coverage   96.34%   96.34%           
=======================================
  Files         243      243           
  Lines       55284    55285    +1     
=======================================
+ Hits        53261    53262    +1     
  Misses       2023     2023           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@narcis-radu narcis-radu requested a review from a team October 8, 2024 13:33
libs/blocks/media/media.js Outdated Show resolved Hide resolved
Copy link
Contributor

@overmyheadandbody overmyheadandbody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions before we rush into this :)

libs/blocks/media/media.js Outdated Show resolved Hide resolved
libs/blocks/media/media.js Show resolved Hide resolved
libs/blocks/media/media.js Show resolved Hide resolved
Copy link
Contributor

@overmyheadandbody overmyheadandbody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for integrating the feedback!

libs/blocks/media/media.js Show resolved Hide resolved
@SilviuLCF SilviuLCF self-requested a review October 8, 2024 14:26
Copy link

@SilviuLCF SilviuLCF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mokimo mokimo changed the title Clickable app and playstore links MWPW-160061: Clickable App and Playstore links Oct 8, 2024
@milo-pr-merge milo-pr-merge bot merged commit 47f1c0d into adobecom:stage Oct 22, 2024
17 of 18 checks passed
@milo-pr-merge milo-pr-merge bot mentioned this pull request Oct 22, 2024
mokimo added a commit that referenced this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants