MWPW-160834: Clickable App and Playstore links #3074
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3074 +/- ##
==========================================
+ Coverage 96.43% 96.45% +0.01%
==========================================
Files 245 246 +1
Lines 55727 55914 +187
==========================================
+ Hits 53740 53930 +190
+ Misses 1987 1984 -3 ☔ View full report in Codecov by Sentry. |
|
mokimo
changed the title
There was a problem hiding this comment.
Although I don't think the mobile app icon section is completely solved for, I understand that we want to have them on the same line for now. @SilviuLCF, it might be worth opening another follow-up story to address the spacings properly and handle RTL. Accessibility-wise, this is also less than ideal, as a screen reader user would not understand the purpose of the links; they don't contain any text, nor do they have any aria-label. We should aim to fix all of these in a future PR.
|
Reminder to set the |
There was a problem hiding this comment.
Verified, testing details
https://jira.corp.adobe.com/browse/MWPW-160834
Description
Small addition to #3021 to resolve the buttons being on top of eachother.
Before:
After:
Resolves: MWPW-160834
Test URLs:
Milo
CC