MWPW-152455 added handling of "no placeholders" case for parsePlaceholders() #3007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3007 +/- ##
=======================================
Coverage 96.34% 96.34%
=======================================
Files 243 243
Lines 55284 55286 +2
=======================================
+ Hits 53261 53263 +2
Misses 2023 2023 ☔ View full report in Codecov by Sentry. |
denlight
changed the title
mokimo
reviewed
Oct 4, 2024
vgoodric
approved these changes
Oct 7, 2024
vgoodric
reviewed
Oct 7, 2024
vgoodric
reviewed
Oct 7, 2024
vgoodric
reviewed
Oct 7, 2024
denlight
commented
Oct 7, 2024
| @@ -655,17 +655,19 @@ function parsePlaceholders(placeholders, config, selectedVariantName = '') { | |||
| 'value', | |||
| 'other', | |||
| ]; | |||
| const [val] = Object.entries(placeholders[0]) | |||
There was a problem hiding this comment.
it was breaking here, where it was trying to deconstruct an array that was found by find function. But when nothing was found const [val] would break because undefined is treated like an array
vgoodric
changed the title
mokimo
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: MWPW-152455
QA Instructions: The before link has an error message the after link does not:
MEP Error parsing manifests: TypeError: undefined is not iterable (cannot read property Symbol(Symbol.iterator))
Test URLs:
Psi-check: https://mwpw-152455--milo--adobecom.hlx.page/?martech=off