Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rtd theme #232

Merged
merged 1 commit into from
Oct 9, 2023
Merged

fix rtd theme #232

merged 1 commit into from
Oct 9, 2023

Conversation

FoamyGuy
Copy link
Contributor

Same fix from: adafruit/Adafruit_CircuitPython_TestRepo#49

as well as in the core: adafruit/circuitpython#8322

I've confirmed successful rtd builds with the test repo using this fix: https://readthedocs.org/projects/adafruit-circuitpython-testrepo/builds/

Copy link
Member

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@FoamyGuy
Copy link
Contributor Author

FoamyGuy commented Sep 11, 2023

Also relevant along with this, here is the PR for Adabot to add the patch for this fix (although it may still need tweaking I think): adafruit/adabot#353

And here is a draft PR in one library with this change that the patch was generated from: adafruit/Adafruit_CircuitPython_DisplayIO_SSD1306#34

@FoamyGuy FoamyGuy merged commit 873dd76 into adafruit:main Oct 9, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants