Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix docs badge link in readme, attempt sphinx theme fix #49

Merged
merged 3 commits into from
Aug 28, 2023

Conversation

FoamyGuy
Copy link
Contributor

This attempts the same fix that was applied in the core from here https://github.com/adafruit/circuitpython/pull/8322/files

While making this change I noticed the badge also linked to a different library so swapped it to this one.

@FoamyGuy
Copy link
Contributor Author

It turns out that pytest returns an exit code of 5 when "no tests ran" occurs. And it seems to assume tests will follow the naming convention something_test or test_something. Ours was only test before which was causing it not to be found and run, which then led to that exit code 5 which caused the action to fail.

The latest commit renames the file to test_test.py so that it will be found and executed as a test and hopefully allow the actions to pass.

@FoamyGuy
Copy link
Contributor Author

Merging this to try to validate the RTD fix will work.

@FoamyGuy FoamyGuy merged commit a7c4550 into adafruit:main Aug 28, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant