Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding rtd theme patch #353

Merged
merged 3 commits into from
Sep 18, 2023
Merged

adding rtd theme patch #353

merged 3 commits into from
Sep 18, 2023

Conversation

FoamyGuy
Copy link
Contributor

@FoamyGuy FoamyGuy commented Sep 11, 2023

This change adds the patch that goes along with this cookiecutter PR: adafruit/cookiecutter-adafruit-circuitpython#232

It resolves an issue that some repos have with the docs build that occurs inside of RTD.

Copy link
Contributor Author

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is my first time using the adabot patch functionality (and really git patch more generally). I'm not sure if I made the patch file correctly.

In order to make it I used a commit in this repo: adafruit/Adafruit_CircuitPython_DisplayIO_SSD1306#34 with the desired changes.

Then inside of PyCharms git GUI I found that commit and used right click -> create patch which generated the file I've added here.

patches/11SEPTEMBER2023_fix_rtd_theme.patch Outdated Show resolved Hide resolved
@FoamyGuy FoamyGuy marked this pull request as ready for review September 11, 2023 16:56
@kattni kattni merged commit bfeb949 into adafruit:main Sep 18, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants