Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce type annotations in the CI #7513

Closed
joejuzl opened this issue Dec 10, 2020 · 3 comments
Closed

Enforce type annotations in the CI #7513

joejuzl opened this issue Dec 10, 2020 · 3 comments
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework area:rasa-oss/infrastructure 🚅 All things related to infrastructure or deployments type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.

Comments

@joejuzl
Copy link
Contributor

joejuzl commented Dec 10, 2020

Type annotations on method definitions are part of our code conventions.
We are seeing lots of PR review comments suggesting adding type annotations.
We should add it to the CI so it is automated.
This will reduce PR review burden, and help maintain our code quality.

Thoughts:

  • Could be done either using mypy or pylint
  • Should only be run on code diffs so we can incorporate it incrementally.
@joejuzl joejuzl added type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style. area:rasa-oss 🎡 Anything related to the open source Rasa framework labels Dec 10, 2020
@wochinge wochinge added area:rasa-oss/infrastructure 🚅 All things related to infrastructure or deployments and removed type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR labels Jan 29, 2021
@tczekajlo
Copy link

I'm not sure if the issue should be in the infra board cc @m-vdb @mprazz

This was referenced Mar 18, 2021
Closed
Closed
Closed
Closed
@wochinge
Copy link
Contributor

  • --disallow-untyped-calls: 50 issues
  • --disallow-untyped-defs: 299 issues
  • --disallow-incomplete-defs: 247 issues

This was referenced Mar 18, 2021
Closed
Closed
Closed
@joejuzl
Copy link
Contributor Author

joejuzl commented May 7, 2021

@wochinge can this be closed now? Or are there more to enforce still?

@wochinge wochinge closed this as completed May 7, 2021
This was referenced Jul 6, 2021
Closed
Closed
This was referenced Jul 12, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework area:rasa-oss/infrastructure 🚅 All things related to infrastructure or deployments type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@joejuzl @wochinge @tczekajlo