Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mypy: Disallow defining functions with incomplete type annotations #8247

Closed
2 tasks done
wochinge opened this issue Mar 18, 2021 · 0 comments · Fixed by #8354
Closed
2 tasks done

mypy: Disallow defining functions with incomplete type annotations #8247

wochinge opened this issue Mar 18, 2021 · 0 comments · Fixed by #8354
Assignees
@wochinge
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.

Comments

@wochinge
Copy link
Contributor

wochinge commented Mar 18, 2021 •
edited
Loading

Parent issue

To enforce type annotations which should start running mypy with the --disallow-incomplete-defs flag.
This currently causes: 247 issues

Definition of Done:

  • the Rasa Open Source CI runs make types with the --disallow-incomplete-defs
  • all detected mypy issues are fixed
@wochinge wochinge added type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style. area:rasa-oss 🎡 Anything related to the open source Rasa framework labels Mar 18, 2021
@wochinge wochinge mentioned this issue Mar 18, 2021
Closed
2 tasks
@wochinge wochinge self-assigned this Mar 29, 2021
@wochinge wochinge mentioned this issue Apr 1, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wochinge wochinge

Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

enforce complete type annotations RasaHQ/rasa
1 participant
@wochinge