Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mypy: Enforce remaining type annotations #8248

Closed
2 tasks
wochinge opened this issue Mar 18, 2021 · 0 comments · Fixed by #8393
Closed
2 tasks

mypy: Enforce remaining type annotations #8248

wochinge opened this issue Mar 18, 2021 · 0 comments · Fixed by #8393
Assignees
@ancalita
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.

Comments

@wochinge
Copy link
Contributor

wochinge commented Mar 18, 2021 •
edited
Loading

Parent issue

To enforce type annotations which should start running mypy with the --disallow-untyped-defs and --disallow-untyped-decorators flag.

Currently blocked by:

This currently causes: 52+x issues

Definition of Done:

  • the Rasa Open Source CI runs make types with the --disallow-untyped-defs and --disallow-untyped-decorators
  • all detected mypy issues are fixed
@wochinge wochinge added type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors. area:rasa-oss 🎡 Anything related to the open source Rasa framework labels Mar 18, 2021
@wochinge wochinge changed the title mypy: Enfoce type annotations everywhere mypy: Enforce type annotations everywhere Mar 18, 2021
@wochinge wochinge changed the title mypy: Enforce type annotations everywhere mypy: Enforce remaining type annotations Mar 18, 2021
@wochinge wochinge added type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style. and removed type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors. labels Mar 19, 2021
@ancalita ancalita assigned ancalita and unassigned wochinge Apr 6, 2021
@ancalita ancalita mentioned this issue Apr 8, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ancalita ancalita

Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add missing type annotations RasaHQ/rasa
2 participants
@wochinge @ancalita